Repository navigation
refactor(cli): retire obsolete pre-Turn Codex CLI pilot stack and ratchet module budget - #8884
Conversation
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · reasoning_effort=max
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
评审提交 ea56654db85a2e2a54cedf33ac986fafb2180835,不可变对照 f15ebdd16b5eb8cd01b2d112a3a0fe866b0f3486。未发现阻断问题。
动机 / Motivation
使用 Codex CLI 首次连接项目、随后继续已授权任务的用户,以及维护 CLI 入口的开发者。
原来首次设置旁边还保留十五个旧探测、证明和调度命令,容易把实验性规划包误当作当前执行入口;候选保留可见 TUI 设置,将显式后台执行集中到既有 LoopX Turn。
五个保留入口的完整输出在同输入基线与候选中相同,三轮隔离执行及无副作用重放通过;旧命令明确退役并返回参数错误。
本次不实现同一打开 TUI 的自动附着,不运行付费模型,也不改变准入、独立验证或结算权限。
同一打开 TUI 的安全附着仍未资格化;旧诊断命令的外部脚本需要迁到已披露的设置或 Turn 入口。
改动思路 / Approach
删除的是已被当前设置和 Turn 路径替代的命令及其封闭依赖;保留同一准入、验证与结算 owner,避免继续维护第二套基于帮助文本和布尔证明的调度判断。
当前 PR 交付旧 CLI 表面的完整退役和保留入口的兼容验证;未来可见附着继续受原安全条件约束。
原来的帮助文本分类和手填布尔证明只能描述候选,并不能证明正在打开的 TUI 可安全附着。既有 Turn 已负责显式隔离执行、独立验证、持久写回及一次扣额。只删文档或搬走模块仍会留下另一套可调用规划链,完整移除其封闭依赖更合适。普通设置仍由 Agent 生成并使用既有用户意图,不新增确认、复制配置或学习协议的必经步骤。
具体改动 / Changes
关键代码讲解
register_starter_commands去掉五组旧家族注册,保留 bootstrap、onboarding、start-goal 与 demo;对应 dispatch/export 同步删除。handle_codex_cli_bootstrap_message_command继续调用原 builder,copy-only 与完整 packet 两种输出均做完整对照,未用字段存在代替语义验证。build_codex_cli_bootstrap_message本体保持原可见设置、用户 gate 和后续 guard/结算约束。移除的是其旧 bundle/handoff 兄弟 builder,未引入隐藏执行。build_command_reference_payload与 parser、手册及指南同步移除退役条目;原来使用旧命令的脚本得到明确参数错误。
规格:docs/product/runtimes/codex-cli/codex-cli-automation-driver.md,版本 f15ebdd16b5eb8cd01b2d112a3a0fe866b0f3486;同时核对该版本的 TUI-first contract。TUI-BOOTSTRAP、TURN-OWNER、PRIVATE-AND-EFFECT-BOUNDARY 已实现并复验;VISIBLE-ATTACH-GATE 保持 deferred,不能因删除证明工具而宣称同一打开 TUI 已可自动附着。
全差异68个路径,以删除四个顶层模块、六个包装器、旧 smoke/fixture 和对应文档为主。127→123 的模块预算对应实际删除,没有改扫描根或换目录规避预算。检索当前产品、脚本、技能及测试调用者后,没有保留调用指向这些被删模块。
对主干的风险 / Risks
PASS:受影响 cohort 640项通过、1项平台条件跳过;native host cohort 141项、Turn driver 211项通过;本地 quick premerge 的直接、选择及公开边界检查通过,单提交有 DCO 签署。保留入口五组完整输出基线/候选相同且不改 fixture;刻意只删保留的 bootstrap parser 后,真实 CLI oracle 会失败,候选正常通过。
PASS:真实 CLI 配合本地合成 Codex 子进程完成三轮 start/resume/resume,独立校验三个编号产物、三次扣额,重放无 host/write/spend 效果。这里未调用真实模型。安装 archive 的 doctor、catalog 和 bootstrap 检查在补齐本头 chat 构建产物后通过。
最初 archive 检查在基线和候选都因缺少生成 bundle 失败,fixture 的 archive 又不含可回退构建的 apps;保留该失败,不归咎于本次退役。机器默认根冲突也影响未隔离的旧 bootstrap smoke;隔离实际入口对照通过。未查询托管 CI。主要兼容成本是外部旧诊断脚本需要迁移,当前指南披露了替代入口;已有 Goal、session 和 receipt 不需迁移。
语义与 CI 对齐
复用现有 Turn 词汇和 owner,删除旧局部探测词汇;没有新通用业务状态。生成设置指令全文保持,文档删除的是旧命令教学,人工优先、idle/visible attach、具体用户 gate、验证后写回扣额仍在原算法和安全规则内。
我的整体评价 / Verdict
这是 justified_increment:清理当前执行入口旁边的旧决策链,有完整保留路径验证。long_horizon 为 preserved,用户体验是 accepted_tradeoff:普通用户路线保持,旧诊断消费者迁移。边界和迁移成本相称,未用净删行数或绿色检查证明整个 Codex CLI 目标完成。
检查了 CLI、手册和 Codex CLI 文档路径;本头没有网页、组件、样式或其他渲染呈现改动,因此无需截图。
未覆盖实际付费模型、已安装 Windows 或同一打开 TUI 的真实附着。APPROVE 只针对这个未变化 head;合入权限及 GitHub readiness 单独处理。
English verdict: APPROVE at ea56654. Retained entrypoints and governed three-Turn execution passed; legacy diagnostic removal is explicit.
ea56654 to
e2dab80
Compare
|
This pull request has merge conflicts with Choose the remote for the base repository, not an out-of-date fork. git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEADFor a same-repository clone whose Keep the DCO |
…chet module budget Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
e2dab80 to
9d818b9
Compare
Summary
Retires the obsolete pre-Turn Codex CLI pilot/proof-fixture stack superseded by
loopx turn(loopx/control_plane/turn_driver/codex_cli.py),start-goal, andcodex_appheartbeat, and ratchets down the top-level module budget (68 files changed, 72 insertions(+), 10893 deletions(-)— -10,821 net lines).What Changed
codex-cli-tui-bootstrap-smoke-bundle,codex-cli-exec-handoff,codex-cli-one-message-loop-pilot,codex-cli-visible-local-driver-pilot,codex-cli-bounded-visible-pilot-adapter,codex-cli-visible-first-response-capture-plan,codex-cli-visible-attach-acceptance,codex-cli-visible-driver-plan,codex-cli-local-driver-plan,codex-cli-visible-driver-run,codex-cli-session-probe,codex-cli-visible-session-proof,codex-cli-runtime-idle-detector,codex-cli-local-scheduler-tick,codex-cli-local-scheduler-exec), while keeping live shipped surfaces (codex-cli-bootstrap-message,agent-onboard,bootstrap-command-pack,start-goal,new-project-prompt, andloopx/control_plane/turn_driver/codex_cli.py) intact.-3,767lines) and ratchetedtests/architecture/top_level_module_budget.json(128 -> 124onorigin/maincommit0514512ee7fbdf5548c88d07763a41dbfc5df931, reflecting the-4module removal while unmerged PR#8934keepsloopx/release_metadata.pyat the top level):loopx/codex_cli_probe.pyloopx/codex_cli_probe_markdown.pyloopx/codex_cli_runtime_probe.pyloopx/codex_cli_scheduler.pyloopx/cli_commands/wrappers (-959lines) and cleaned upstarter.py,starter_bootstrap.py,starter_bootstrap_registration.py,__init__.py,cli_runtime.py,help_surface.py,project_prompt.py(build_codex_cli_tui_bootstrap_smoke_bundle,build_codex_cli_exec_handoff, and their markdown renderers),man/loopx.1(regenerated viascripts/render-manpage.py),loopx/canary/planner.py, andloopx/canary/module_metric_baseline.json:starter_visible_pilot.py,starter_visible_driver.py,starter_visible_common.py,starter_scheduler.py,starter_session_runtime.py,starter_runtime_idle.py20examples/*-smoke.pyfiles,6JSON fixtures underexamples/fixtures/codex-cli-visible-proof/,tests/control_plane/test_codex_cli_scheduler_effect_program.py, and5pilot/proof docs underdocs/product/runtimes/codex-cli/), and updated remaining tests, smokes, and docs (tests/test_release_smoke_archive_helpers.py,examples/canary/catalog-planner-smoke.py,examples/cli-help-manpage-smoke.py,examples/cli-command-module-size-ownership-command-modularization-smoke.py,examples/codex-cli-bootstrap-message-smoke.py,examples/codex-cli-first-run-rehearsal-smoke.py,examples/release/codex-cli-no-clone-release-verification-smoke.py,docs/guides/getting-started.md,docs/concepts/interaction-pattern-catalog.md, anddocs/product/runtimes/codex-cli/).Verification (rebased head
9d818b9d73onorigin/main0514512ee7)uv run --extra test ruff check <modified .py files>:All checks passed!uv run --extra test python -m mypy:Success: no issues found in 17 source filesuv run --extra test python -m pytest -q --no-cov tests/architecture/test_top_level_module_budget.py tests/architecture/test_semantic_vocabulary_drift.py tests/test_release_smoke_archive_helpers.py tests/canary/test_maintainability_ratchet.py tests/canary/test_repository_root.py tests/test_cli*.py tests/test_codex*.py tests/test_onboarding_command_platform.py tests/control_plane/test_goal_prompt_dispatch.py:749 passed, 5 skippeduv run --extra test python -m pytest -q --no-cov tests/architecture/test_control_plane_import_boundaries.py -k "not test_public_facade_compatibility_entries_have_contract_evidence":30 passed, 1 deselected(test_public_facade_compatibility_entries_have_contract_evidencehas a pre-existingorigin/mainfailure on untouchedloopx.status/loopx.quotareexports).HOMEuv run --extra test loopx --format json canary premerge --from-git-diff --git-diff-base origin/main:passed selected=19 failures=0,merge_gate_passed: true.examples/cli-help-manpage-smoke.py,examples/codex-cli-bootstrap-message-smoke.py,examples/canary/catalog-planner-smoke.py,examples/codex-cli-first-run-rehearsal-smoke.py,examples/release/codex-cli-no-clone-release-verification-smoke.py.