Skip to content

Recover captured images from legacy Lark private replies - #8999

Merged
loopx-agent merged 1 commit into
mainfrom
codex/lark-historical-native-reply-images-20261118
Nov 18, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/lark-historical-native-reply-images-20261118

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

What changes

Older Codex project replies could reach the original Lark private chat with their image captions and no image attachments. The existing historical recovery only accepts public URL images.

The same recovery worker can now read verified snapshots staged by the host operator. The manifest pins the original binding, Turn, text-only reply, answer digest and ordered image digests. The snapshots live in a private directory for that exact Turn. The worker checks the current bound-owner project grant and rereads both original Lark messages before using the existing image upload and byte readback. The original text and Turn are preserved.

Validation

  • 41 focused pytest cases passed, including the historical URL path, captured image order and bytes, wrong Turn, changed or symlinked files, Stop, revocation and unknown upload or send outcomes.
  • A synthetic provider verifies the original sender and chat, the native image payload, a single send and exact bytes after a worker restart.
  • Live provider adoption and historical image delivery are tracked separately.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.2-sol · OpenAI · runtime_reported · effort=max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机 / Motivation

已收到图题、缺原图的飞书私聊所有者。 既有历史补图只接受公开 URL,无法使用已找回的原轮次图片。 漏图回复持续欠交付,完整重跑会再次执行业务。

同一测试在目标版本无法补发,当前提交沿原私聊交付两张有序图片。 模拟提供商逐张返回完全一致的图片字节。 继续使用原回复、受众、权限和发送器。 正式运行版本采用、飞书可见性和真实历史图片投递仍需单独验收。

改动思路 / Approach

普通、已授权工作区写入的 Codex 项目飞书私聊。操作员保存在私有宿主目录中并逐张核验的原图,按既有回复补图路径处理。 既有私聊 worker 处理原文件和原回执,工作区路径不可作为补图输入。 原补图 worker 重新校验源消息、已送达正文和当前会话授权,再沿同一上传与回执链处理。原正文和完成记录保留。

具体改动 / Changes

  • 补图描述绑定原请求、回复及答案摘要。只允许普通项目私聊的独立历史路径,按固定轮次目录查找文件并拒绝符号链接和摘要不符。私聊补图
  • 既有上传、原生图片与字节读回承担实际效果。错误轮次、编辑、停止和撤权均阻止上传,已经发生或未知的效果保持在原记录内。恢复与读回
  • 对照目标版本 afba084 的 docs/architecture/rfcs/app-conversation-and-async-inbox-v0.md 核查两项约束。original-reply-binding 维持原请求、原应用和受众的绑定。original-provider-effects 用现有回执和字节回读处理未知效果,原有 URL 补图继续采用已有来源校验。原会话协议

对主干的风险 / Risks

风险集中在旧回复的文件范围、权限变化和发送效果未知。41 项聚焦测试、722 项相邻测试和标准 premerge 已通过。那些用例覆盖原生图片顺序、逐张字节、重启和未知效果。权限撤销及原消息变更都阻止新的图片发送。正式运行版本采用、飞书可见性和真实历史图片投递仍需单独验收。

我的整体评价 / Verdict

批准当前提交的历史补图路径。它沿用原发件应用、原私聊与单一发送记录,避免重跑已结束的业务。原文字送达仍有独立记录,补图可凭原消息和下载的图片复核。

English verdict: APPROVE d80c1d1. Recover verified original snapshots through the existing private Lark outbox and keep unknown effects pending. Installed runtime adoption and live client display remain to be verified.

@loopx-agent
loopx-agent merged commit f9bb5e3 into main Nov 18, 2026
20 of 42 checks passed
@loopx-agent
loopx-agent deleted the codex/lark-historical-native-reply-images-20261118 branch November 18, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant