Skip to content

Report verified Python package changes during update - #9036

Open
loopx-agent wants to merge 100 commits into
mainfrom
codex/python-update-observed-change-20261119
Open

loopx-agent wants to merge 100 commits into
mainfrom
codex/python-update-observed-change-20261119

Conversation

@loopx-agent

@loopx-agent loopx-agent commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

loopx update apply compares Python package version and fingerprint before and after pip or pipx runs. An unchanged wheel reports changes_applied: false while host material and stale services can still be reconciled. A package change remains observable if a later authority upgrade fails; that failure prevents service activation.

The updater rechecks package identity after host validation and refuses to certify or activate a different concurrent installation. It reuses Doctor’s distribution-owned launcher for background workers and environments outside PATH. Managed services can recover a verified legacy identity without a fingerprint through the existing fenced handoff. Chat retains pending service activation for both changed and unchanged packages. Digest validation uses the canonical owner.

Validation

Updated head dc92914f9f, integrated with main cc5392e953.

  • 458 focused tests passed; 6 platform/native fixtures skipped. Covers pip/pipx identity drift, background worker launcher routing, legacy stale services, authority failure and Chat deferral.
  • Ruff and diff whitespace checks passed.
  • Built the wheel using assets validated against this checkout’s source contract. Installed it into an isolated Python 3.11 environment; module-invoked installation Doctor selected that environment’s console despite an unrelated PATH launcher, and returned a valid package fingerprint. Cleared inherited release/Python routing variables for this check.
  • An initial wheel build lacked generated Chat assets; recovered with source-validated assets. One test attempt exhausted temporary storage; reran successfully after removing this attempt’s disposable build/install directories.
  • Ran the installed CLI with a real pip environment and offline wheels: unchanged 2.4.0 reports no package change; a synthetic 2.4.0.post1 fixture reports a verified change. Authority upgrade, workflow skills, slash commands, final Doctor, extension Doctor and durable operation status succeed. On the changed-package path, an existing isolated SQLite Goal retains its exact Todo records and original operation receipt, and accepts a subsequent task write. The synthetic wheel is only a test fixture.
  • Installed the current wheel with real pipx in an isolated home and environment. Its local-wheel upgrade correctly reports no change, verifies identical before/after fingerprints, completes host and extension validation, and reads back a durable succeeded operation. This covers local-spec pipx behavior; index-driven package changes remain untested.
  • Current release preparation CI refuses public adoption because C1 single-session outcome/full-cost and supported-profile qualification is absent; this gate remains intact. Other canceled/pending checks are not passes.
  • Verified the official 2.3.0 wheel against its PyPI SHA-256, created an original SQLite Goal and Todo with that version, then ran its native updater to this candidate. Original Todo records are identical after upgrade; the original operation receipt is readable and a new task can be written. A real pip package rollback to official 2.3.0 preserves both tasks and the original receipt, permits another task write, and re-upgrades to this candidate with a durable succeeded operation. This validates package rollback and continued SQLite work in an isolated fixture; it does not qualify a full backup/restore or schema-downgrade contract.
  • File-backend migration, original leases/custom configuration, failure-injected recovery and backup restoration, pipx index-driven package changes, native Windows, live LaunchAgent behavior and independent review remain pending. Earlier packaged pip/pipx checks are not claimed as current-head validation.

Related installation ownership work: #9009.

补充 File 故障恢复实测:官方 2.3.0、独立 File Goal、显式自定义机器配置和 hard lease 环境中,实际 pip 升级遭遇 ENOSPC,pip 恢复原 2.3.0。失败后原 Todo 逐字段相同、自定义配置相同、原操作收据可读;原 claim 重放成功,并使用原租约完成新的 Todo 更新。此结果仅证明本次磁盘耗尽后的包恢复与原工作接续;File 成功升级、候选版本原租约保持及显式备份恢复仍未验证。

loopx-agent and others added 4 commits November 14, 2026 10:06
…eipt

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…covery

Preserve the benchmark toolkit public exports and static types while keeping execution and experiment implementations out of metadata discovery. Qualify source and installed Core paths, and reconcile the paired minimal/Standard RFC boundary without changing activation or authority defaults.

Signed-off-by: cicolord <cicolord@outlook.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…und Stop hooks (#8874)

* fix(antigravity): guide fixed-session in-place schedule patrol and bound Stop hooks

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(antigravity): fix exact-surface unbind readback, default registry hooks, and skill isolation

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…structural moats (#9035)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
#8955)

Verify #8577 (77eece8) and #8879 (3d6fd2e) on main against DSH pause/unsettled-recovery regressions across file and sqlite providers:
- Paused Goals (goal_stopped and compute_quota_zero) must keep should_run=False and pause_cause without projecting unsettled_host_turn_recovery, setting closeout_required=True, setting a settlement_effect_id/recovery_effect_id, or consuming the bounded 3-admission recovery budget.
- Resuming restores unsettled_host_turn_recovery with admissions_without_progress == 0.

Closes #8505
Closes #8563

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…livery (#9040)

Align developer workflow docs and PR review/merge skills so managed Goals
that configure wait_for_ci=false explicitly pass --registry and --goal-id
across worktree/subagent invocations and complete review, readiness, and
eligible self-merges locally without polling asynchronous GitHub CI.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…plore_visual_sink (#8925)

* refactor(lark): slim explore_results below 1,350 lines and extract explore_visual_sink

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(lark): preserve dynamic visual sync status in _sync_packet

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
)

* refactor(lark): slim kanban presentation and extract board module

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(lark): filter null view_ids during partial kanban setup

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, max)

Request changes conclusion (author-owned PR; GitHub blocks formal self-review)

[P2] 用最终 Doctor 校验包身份后再声明服务已就绪

pip/pipx 保留包 A 后,另一安装进程在两次 Doctor 之间换入同版本包 B。最终 Doctor 已看到 B,当前 head 仍将早期 A 写入 installed_runtime_identity,返回成功与 already_active,并保留实际仍在提供 A 的 Status。两种驱动以同一顺序复现。base 在同一场景回报 B,服务读回也与 B 一致。把早期和最终包键核对纳入成功与 activation 门槛,身份变化时要求重试。 相关代码

动机 / Motivation

通过 pip 或 pipx 更新 LoopX 的调用者需要知道实际落盘的包和 Status/Chat 正在服务的运行时。base 将包管理器成功视为已更新。当前 head 比较早期包身份,使同 wheel 重跑可以保持健康进程。同版本真实换包要与普通重跑区分。成功读回和服务状态都需要对应同一运行时。独立验证使用受控进程和本地 HTTP。

改动思路 / Approach

复用当前 Python 安装所有者、Doctor 与 launchd 就绪核验。早期校验可以阻止未知包身份继续执行。问题集中于安装身份从早期读回传给最终结果与服务就绪的交接。分段验证安装结果和正在服务的版本。两种驱动的同版本不变、同版本真实换包和两次 Doctor 间发生换包均以相同输入对照。

具体改动 / Changes

精确 head 101051ab29f23b6814bf145c02a1efb07e45f6ae,diff base e235cde9c8d1c4e673af4aefd6f304b7397bba07,8 个文件 +324/-89。逐项复核 same-wheel-no-op、same-version-fingerprint、verified-activation。验收约定

关键代码讲解

  • 包管理器结束后先读安装 Doctor。相同版本的 A→B 指纹变化也可以区分。源码
  • 最终 Doctor 退出码进入 runtime_ready,返回的安装身份和 activation 仍取早期读取。源码
  • 现有 Status 的 loopback 会返回旧 A,只有早期 A 相等时便可跳过重启。源码
  • 桌面升级从同一执行记录读取期望身份,早期值会继续传给下游。源码

对主干的风险 / Risks

原三组聚焦测试在 base 通过 140 项,在 head 通过 149 项,两边各跳过 6 项。独立负例实际执行服务就绪 HTTP 读回,观察到两种驱动均保留了旧进程。安装进程和 launchd 采用受控替身。

语义与 CI 对齐

同 wheel 的稳定路径可以保留。结束时只有与最终安装一致的身份才能用于成功回执和服务就绪判断。

我的整体评价 / Verdict

请修复最终 Doctor 与早期包身份不一致时的成功回执,并覆盖两个包管理器的时序负例。读回来自同一安装身份后再认证当前服务。稳定同包重跑无需额外中断。

English verdict: REQUEST_CHANGES. The Python update can report successful, already-active completion for an earlier package while the final Doctor has read a different fingerprint. Revalidate final identity before certifying readiness.

Comment thread loopx/self_update.py
restart_services_for_runtime_activation(
changes_applied=updated["changes_applied"],
runtime_ready=runtime_ready,
installed_python_identity=installed_identity if identity_verified else None,

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] 用最终 Doctor 校验包身份后再声明服务已就绪

pip/pipx 保留包 A 后,另一安装进程在两次 Doctor 之间换入同版本包 B。最终 Doctor 已看到 B,当前 head 仍将早期 A 写入 installed_runtime_identity,返回成功与 already_active,并保留实际仍在提供 A 的 Status。两种驱动以同一顺序复现。base 在同一场景回报 B,服务读回也与 B 一致。把早期和最终包键核对纳入成功与 activation 门槛,身份变化时要求重试。

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · Gemini · Google (self_reported)

Request changes conclusion (author-owned PR; GitHub blocks formal self-review)

动机 / Motivation

通过 pip 或 pipx 安装或运维 LoopX 的用户与升级自动化流程在执行 loopx update apply 或 loopx upgrade 时会触发包更新、宿主物料同步与本地托管服务激活。改造前即使 pip 或 pipx 因同版本重装未更换 wheel,应用侧也一律返回 changes_applied 为 true 并强制重启所有未绑定服务;改造后通过安装前后的版本与文件指纹比对区分真实包变化与同包空转,但实际通过默认 CLI 后台 worker、无 PATH 虚拟环境或跨预指纹版本原地升级时仍会误报延期或跳过刷新。在虚拟环境处于 PATH 且无已绑定 LaunchAgent 的隔离测试中,同 wheel 重跑可如实报告 changes_applied 为 false 并刷新宿主物料;但现有测试集存在 2 项回归失败,且后台 worker 绑定服务重连、无 PATH 环境读回与旧版无指纹服务原地升级三类真实路径均已验证失败。本次改动不切换 pip/pipx 的包管理所有权,不引入在线仓库元数据对比,也不扩展 Windows 原生归档自动更新或完整 LaunchAgent 跨版本迁移。

由于实际验证暴露出既有测试回归以及真实 CLI 后台 worker、非 PATH 虚拟环境和跨无指纹版本原地升级三条链路阻断,本 PR 当前不能以可用状态合入主干,需先修复已复现的回归与入口断链后再复审。

改动思路 / Approach

复用 release_runtime_identity、doctor --installation-only、align_managed_runtime 与 update_with_prompts 等既有所有权边界来拆解包更新、身份核验与服务切换;当前放置边界合理,但实际默认 CLI 入口与旧版服务路径尚未闭环。本 PR 将变更限定在 Python 包指纹读回、未变化时的宿主物料延续、以及 macOS 标准托管服务的同路径指纹比对与保活,未新建独立调度或控制平面决策层。

从调用链路来看,入口为 loopx/self_update.py 的 _execute_python_distribution_update,先记录当前进程所属包的 release_runtime_identity,在 pip/pipx 执行完毕后调用隔离参数的子进程运行 doctor --installation-only 读取安装后身份,再据此计算 changes_applied 并传入 restart_services_for_runtime_activation;提示词协同入口 loopx/control_plane/heartbeat/installed_prompt_update.py 则在 package_identity_verified 为真时允许继续同步托管提示词。在状态模型上,package_identity_verified 与 changes_applied 属于基于安装前后指纹比对推导出的派生投影,而非独立持久化真值;already_active 也是基于本地 launchd 状态与 HTTP /?readiness=1、/api/chat/readiness、/api/chat/capabilities 探针推导的运行时结果。

本次审阅同时发现一个需要与既有实现对照的关键权衡:正常用户执行 loopx update apply 时,support_control_update 会通过 update_operation 启动 python -P -c ... 后台 worker,而非直接运行 loopx 控制台脚本;但 restart_services_for_runtime_activation 在未收到显式 installed_bin 时仍依赖 current_script_invocation_path() 检查 sys.argv[0],导致后台 worker 在遇到已绑定 LoopXRuntimeBinding 的 macOS 服务时必然失败。这一设计假设测试中通过 monkeypatch 绕过,未覆盖真实 CLI 启动链。

具体改动 / Changes

精确 head 101051ab29f23b6814bf145c02a1efb07e45f6ae,diff base e235cde9c8d1c4e673af4aefd6f304b7397bba07,共改动 8 个文件(+324 / -89)。对照基线契约文档 docs/guides/installing-loopx.md(基线提交 e235cde9c8d1c4e673af4aefd6f304b7397bba07)中的更新与运行时身份规范,各验收条款映射如下:

  • INST-FINGERPRINT-1(同版本不同字节 wheel 通过 package_fingerprint 区分):implemented,由 _python_package_key(loopx/self_update.py)实现并在真实 wheel 空转与 .post1 升级实测中通过。
  • INST-LAYER-READBACK-2(包获取、宿主物料刷新、核心激活与扩展检查分层推进且现有激活测试保持兼容):not_met,tests/test_chat_runtime_activation.py 中 python_pip/python_pipx 延迟激活测试因缺少安装读回模拟而直接失败,且同一套更新调用在无 package_fingerprint 的旧版服务或非 PATH 虚拟环境下阻断后续宿主层。
  • INST-WORKER-ACTIVATION-3(更新通过自有后台 worker 持续执行并完成受管服务切换):not_met,update_operation 的 -c worker 触发 current_script_invocation_path() 返回 None,使已绑定 macOS 服务的 loopx update apply 误报 service_runtime_unverified 延期失败。
  • INST-MODULE-ENTRY-4(通过所属 Python 环境及其模块入口可执行可靠更新与读回):not_met,installation_readback 通过 python -E -P -m loopx.cli doctor --installation-only 执行,在虚拟环境未加入 PATH 时因 command_available 失败而中止;且在有无关 loopx 位于 PATH 时会借用错误可执行路径。

关键代码讲解

  • loopx/self_update.py _execute_python_distribution_update(L1023-L1214):改用 [sys.executable, "-E", "-P", "-m"] 隔离调用者 PYTHONPATH 与当前目录并移除 LOOPX_RELEASE_ROOT,在包管理器退出 0 后优先运行 doctor --installation-only 并用 _python_package_key 校验 schema_version 与 64 位 SHA-256 指纹。由此确定 package_identity_verified 与 changes_applied = (previous_key != installed_key);但要求 previous_key 与 installed_key 同为有效指纹,同时移除了从最终 doctor 步骤重新读取 installed_runtime_identity 的逻辑(也引发了与并发评审 #pullrequestreview-5965135400 指出的二次读回窗口不一致问题)。
  • loopx/runtime_activation.py restart_services_for_runtime_activation(L331-L419):放行 runtime_ready and (changes_applied or installed_python_identity) 分支,使包未变化时也能核对并按需重启服务;在 macOS 已绑定 LoopXRuntimeBinding 场景下不再于 changes_applied=False 时前置阻塞 managed_chat_activation_guard,转交 align_managed_runtime 内部按需加锁并据 readiness_verified 返回 already_active 或 not_running;未绑定场景先以 managed_services_match_runtime 验证全部 plist 均已服务同指纹包再跳过重启。
  • loopx/hosts/managed_service_runtime.py _serving_identity、managed_services_match_runtime 与 _align_managed_runtime(L343-L390, L545-L553):将 _verify_services 中的本地 HTTP 就绪读回提取为公共辅助 _serving_identity,供 managed_services_match_runtime(要求全部标准 plist 非符号链接、端口与 launchd 状态一致且返回精确相等的 runtime_identity)及 _align_managed_runtime 的同路径原地更新分支复用。
  • loopx/control_plane/heartbeat/installed_prompt_update.py update_with_prompts(L157-L162):在扩展检查失败导致 ok=False 但 install_returncode==0 且 doctor_returncode==0 时,允许通过 execution.package_identity_verified is True 触发已安装自动化提示词的兼容迁移,而无需伪造 changes_applied=True。
  • docs/product/release-readiness.md(L64-L69) 与测试集(tests/test_managed_service_runtime.py、tests/test_self_update_runtime_activation.py、tests/test_self_upgrade.py):补充说明 changes_applied 与 execution.restarted_services 语义,并新增同包空转、未验证身份阻断、未绑定保活与已绑定陈旧服务仅重启陈旧实例的单元测试。

对主干的风险 / Risks

[P1] tests/test_chat_runtime_activation.py 在精确 head 存在 2 项明确回归失败

  • 触发条件与路径:在工作树直接执行 pytest tests/test_chat_runtime_activation.py,其中 test_update_keeps_install_readback_but_does_not_claim_deferred_service_is_serving 的 python_pip 与 python_pipx 参数化用例调用 execute_update_plan 并 mock subprocess.run 返回 {"ok": true}。由于 PR 在 loopx/self_update.py#L1108-L1158 强制先执行 installation_readback 并校验证书级 scope=="installation_only" 与指纹,mock 返回被判为未验证身份,后续 doctor 与激活均被跳过,changes_applied 变为 False(预期为 True、restart_status == "deferred")。
  • 最小修复与回归测试:同步更新 tests/test_chat_runtime_activation.py 的 mock fixture 提供 release_runtime_identity 与 installation_only 读回,并补充“包未变化(changes_applied=False)但 Chat 存在未完结任务时陈旧绑定服务仍应进入 deferred”的对照用例。

[P1] 真实 CLI 后台 worker 执行 loopx update apply 时,已绑定 macOS 托管服务必然报 service_runtime_unverified 失败

  • 触发条件与路径:用户通过真实 CLI 执行 loopx update apply 或 loopx upgrade 且本机存在带 LoopXRuntimeBinding 的 com.loopx.status.plist / com.loopx.chat.plist。loopx/cli_commands/support_control_update.py#L216 默认调用 update_operation.start_or_observe 以 [sys.executable, "-P", "-c", entry, ...] 拉起分离 worker(此时 sys.argv[0] == "-c")。_execute_python_distribution_update 调用 restart_services_for_runtime_activation 时未传入可执行路径(installed_bin=None),进入 loopx/runtime_activation.py#L380-L384 后 current_script_invocation_path() 因 sys.argv[0] 不是 loopx 或 entrypoint.py 返回 None,直接抛出 RuntimeActivationDeferred("service_runtime_unverified"),导致实测 rc=1、ok=False、activation_pending=True。单测 tests/test_managed_service_runtime.py#L634 通过 monkeypatch current_script_invocation_path 掩盖了这一缺陷。
  • 最小修复与回归测试:将 archive 的 ~/.local/bin 自定义路径过滤与 Python 发行版服务对齐目标路径分离,在 update_operation 或 _execute_python_distribution_update 中显式解析当前分布记录的控制台脚本(如通过 installed_loopx_distribution / sys.executable 同级脚本)传给 align_managed_runtime;补充不 mock current_script_invocation_path 的端到端后台 worker + 绑定 plist 测试。

[P1] 虚拟环境未加入 PATH(或通过 python -m loopx.entrypoint 触发)时,installation_readback 误判失败并跳过全部宿主更新

  • 触发条件与路径:在独立的 pip 虚拟环境目录未加入 PATH 且系统中无其他 loopx 时运行 <venv>/bin/loopx update apply 或文档规定的 python -m loopx.entrypoint update apply。loopx/self_update.py#L1053 通过 python -E -P -m loopx.cli doctor --installation-only 执行读回,此时 sys.argv[0] 为 cli.py,current_script_invocation_path() 返回 None,collect_installation_doctor 回退到 PATH 查找 loopx 失败(command_available: false、ok: false)。真实 wheel 洁净 PATH 实测返回 rc=1、package_identity_verified=False、changes_applied=False,同时跳过了 authority_upgrade、workflow_skills、slash_commands 与服务激活,且 next_action 仍推荐无法在 PATH 找到的 loopx doctor --installation-only;反之若 PATH 上存在另一套不相关 loopx,command_available 会误借该无关路径通过检查。
  • 最小修复与回归测试:让 _execute_python_distribution_update 直接调用所属 Python 发行版的控制台脚本(或使 --installation-only 校验当前分布自带的脚本所有权而非依赖环境变量 PATH),并补充无 PATH 虚拟环境更新及跨环境隔离测试。

[P2] _align_managed_runtime 原地重装升级分支错误拒绝无 package_fingerprint 的旧版活跃服务

  • 触发条件与路径:当已绑定服务仍在运行早先不带 package_fingerprint 的 loopx_runtime_identity_v1(例如旧版本轮子或同虚拟环境从可编辑态原地升级至新 wheel),且新旧可执行路径一致(updated == payload)时,loopx/hosts/managed_service_runtime.py#L545-L552 因条件 and running.get("package_fingerprint") 为假而拒绝将该服务加入 updates,随后在 L581 执行 _verify_services(endpoints, identity) 等待 15 秒并必然因身份不相等抛出 service_runtime_alignment_failed。
  • 最小修复与回归测试:移除 loopx/hosts/managed_service_runtime.py#L550 中冗余的 and running.get("package_fingerprint") 限制(running is not None 已确保排除无响应服务),并补充旧版无指纹 runtime_identity 原地升级到带指纹新版的测试。

除上述问题外,在隔离 wheel 构建与检查中:loopx-core wheel 构建及 test_core_distribution.py / test_installed_core_context.py 采样用例通过;ruff check 全部通过;loopx check 公开边界扫描 8 个文件无告警;canary premerge 中 semantic-vocabulary-drift-smoke.py 因孤立工作树缺少 node_modules(npm ci --ignore-scripts 未运行)而环境失败,非 TS 的 Python 词汇与存量棘轮项核验通过;mypy 在修改行存在 5 处沿用既有未标注风格的类型告警(dict 泛型参数缺失及 lifecycle.get 潜在 None)。另需注意与并发评审 #pullrequestreview-5965135400 核实一致的一点:self_update.py#L1158 移除了由最终 doctor 更新 installed_runtime_identity 的逻辑,若两次读回之间发生并发包替换会出现身份错位。

我的整体评价 / Verdict

综合行为、真实包更新链路与既有测试核验结果:problem_context.outcome_impact 中 long_horizon 为 regression、user_experience 为 regression,原因在于默认 CLI 后台 worker 无法完成已绑定 macOS 服务的更新核验(必然卡在 service_runtime_unverified 延期态)、非 PATH 虚拟环境 installation_readback 误拒真实更新并跳过宿主物料刷新,以及旧版无指纹服务的原地替换在 15 秒超时后失败。visual_review 为 not_applicable,原因是:本次改动仅涉及 CLI 更新逻辑、macOS LaunchAgent 服务激活与发布文档,未修改任何 Web 前端界面或视觉呈现。未核验范围(unverified_scope):none。observable_semantics 为 unintended_drift;code_volume 与 change_proportionality 本身符合必要且归属合理的改动尺度(architecture_assessment 为 retain),authority_semantics 与 default_off_isolation 保持合规;词汇方面仅在 runtime_activation 与 self_update 沿用既有字符串状态值,未新增或篡改 vocabulary_v0.json 受控词表。

本次审阅仅针对精确 head 101051ab29f23b6814bf145c02a1efb07e45f6ae 得出结论,不沿用旧评估;主要未直接触发的边界包括本机未安装 pipx 实包工具(通过真实 pip wheel 与单测替代覆盖)、原生 Windows 控制台升级以及真实 launchctl 守护进程切换。需完成上述 4 项修复并解决与并发评审指出的最终 doctor 身份对齐后,方可重新提交复审。

English Verdict: REQUEST_CHANGES — Exact head 101051a breaks 2 existing tests in tests/test_chat_runtime_activation.py, fails macOS bound-service activation via the detached update_operation worker (service_runtime_unverified), fails installation_readback when the owning venv is not on PATH, and blocks in-place upgrades from pre-fingerprint services in _align_managed_runtime.

loopx-agent and others added 9 commits November 19, 2026 05:25
…on-recovery-pr-20261114

Prevent overlapping Todo validators and recover their original completion receipt
Signed-off-by: cicolord <cicolord@outlook.com>
Signed-off-by: cicolord <cicolord@outlook.com>
…n-demand-20261119

Keep empty Todo queues out of ordinary Worker context
…-20261119

Defer Yardstick evaluation until explicitly selected
…e-20261119

refactor(core): keep benchmark execution out of capability discovery
Signed-off-by: huangruiteng <huangrt01@163.com>
…k-source-20261116

Reject recalled Lark messages before admission or reply
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
… of mid-turn failed reports (#9077)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…onfirmation (#9081)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…ker boundaries (#9083)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
* refactor(content-ops): slim surface module and eliminate Any

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(content-ops): reject malformed angle source_item_ids containers

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…Goal (#9085)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…9087)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@mergify

mergify Bot commented Nov 19, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with main and cannot be merged
until they are resolved. Please rebase or merge the base branch, @loopx-agent.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/main and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Nov 19, 2026
loopx-agent and others added 17 commits November 20, 2026 00:50
…cope runtime revision in handoffs query (#9088)

Eliminate the remaining O(N) Effect runtime RPCs and uncached runtime fingerprinting inside tracking.query(): enter effect_runtime_request_scope() for the query, memoize pure history_inspect lifecycle decisions across entries sharing identical Goal refs while holding the Goal lifetime guard, lazily discover legacy ingress files only when external audience recovery needs them, and preserve entry scan order across Goal batches.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…LOC reduction (#8929)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…led releases and extend readiness timeout to 90s (#9089)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
)

* refactor(control-plane): split and slim quota monitor_poll_commit

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(control-plane): preserve legacy lane budget and observation diagnostic order

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…8939)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
… retire ceiling (#8911)

* refactor(native-chat): move steward commission mixin to steward_commands and retire external_conversations ceiling

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(native-chat): respect include_raw_response in retained result recovery

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…project_contexts guard, and retire ceiling (#8920)

* refactor(chat): move session lifecycle mixin to session_open, deduplicate runtime helpers, and retire ceiling

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(chat): drop turn_done_events slot before waking waiters on Thread.start failure

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…le monitor recovery, and cache private delivery scans (#9093)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…very lookups (#9096)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…-execution-pr-20261114

Recover the original Session and Turn from a confirmed Chat task
…rrupt observations (#9098)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…y event summaries (#9100)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…gate blocked follow-ups (#9117)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@mergify mergify Bot removed the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants