Repository navigation
docs(dev,skills): codify local-first verification and zero-CI-wait delivery - #9040
Conversation
…livery Align developer workflow docs and PR review/merge skills so managed Goals that configure wait_for_ci=false explicitly pass --registry and --goal-id across worktree/subagent invocations and complete review, readiness, and eligible self-merges locally without polling asynchronous GitHub CI. Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
Reviewer: model_agent | Gemini (Google Antigravity) | self_reported
动机 / Motivation
在独立工作树或子代理环境中执行 loopx pr-review、就绪检查与合入决策的日常维护者和受管 Agent 会直接遇到此问题。
改动前,开发者文档与评审/合入 skill 未显式要求在工作树中同时传入 --registry 与 --goal-id,调用方常因默认回退到 wait_for_ci=true 而阻塞在异步 CI 队列;改动后,受管工作流明确传递上述参数并遵守 wait_for_ci=false,在本地门禁与精确头评审完成后即可执行合格自合并。
四份文档与 skill 明确对齐了本地优先验证、--registry/--goal-id 显式透传、wait_for_ci=false 不等远端 CI 及 --admin 仅覆盖分支保护限定的完整闭环,同时保持全部技能安装包和 smoke 门禁通过。
非目标与边界:本 PR 不修改任何 loopx/** 可执行运行时代码、CLI 解析逻辑或未配置 Goal 的独立调用默认 wait_for_ci=true 策略,也不放宽精确头评审、双语校验和合入权限门禁。
改动思路 / Approach
保持代码语义单点与零运行时扩散:完全复用既有 pull_request_review.wait_for_ci 配置 owner(ci_policy="not_consulted")与既有 --check-merge-readiness 命令接口,只在开发者文档与评审/合并 skill 四个文本入口对齐调用约束与决策树:
docs/development/README.md在Change Loop / 变更闭环中将本地验证、loopx canary premerge、绑定 Goal 的精确头评审(尊重wait_for_ci=false)与合格即合并串联为标准闭环;docs/development/testing-and-quality.md新增双语小节Local-First Premerge Gate vs. Asynchronous CI / 本地优先门禁与异步 CI,阐明本地确定性门禁与异步 CI 安全网的分工,并明确未配置 Goal 仍保持wait_for_ci=true;skills/loopx-pr-merge/SKILL.md与skills/loopx-pr-review/SKILL.md重点补齐“工作树或子代理省略--registry/--goal-id会悄然回退wait_for_ci=true”的警示,并保留examples/pr-review-command-smoke.py强制约束的<= 190行预算及精确合规短语。
具体改动 / Changes
docs/development/README.md(Change Loop / 变更闭环):更新流程框与中英文说明,明确受管 Goal 开启pull_request_review.wait_for_ci=false后,本地确定性验证 + 显式绑定--registry/--goal-id的精确头评审即构成完整合入前门禁。docs/development/testing-and-quality.md(Local-First Premerge Gate vs. Asynchronous CI / 本地优先门禁与异步 CI):说明ci_policy="not_consulted"的语义及与独立调用默认wait_for_ci=true的隔离边界。skills/loopx-pr-merge/SKILL.md(Configured CI Waiting与Self-Merge Eligibility And Benchmark Exceptions):补充传--registry与--goal-id GOAL的要求,及wait_for_ci=false下仅对作者自持COMMENTED审批或未参考 CI 检查的分支保护拦截使用--match-head-commit HEAD_OID --admin,明确BLOCKED本身不授予合并权限。skills/loopx-pr-review/SKILL.md(管理端评审与--check-merge-readiness段落):收紧表述至恰好190行,既强调工作树必须显式传--registry/--goal-id,又完整保留admin bypass may override a readiness or GitHub policy hold等契约句及禁止引用仓库根AGENTS.md相对路径约束。- 本地实测(head
dba7cae63d301c415f71c43fe33d7927d6ec23cf):pytest -q --no-cov tests/test_workflow_skill_install.pyPASS(32 passed, 2 skippedWindows 用例);loopx check --scan-path ...PASS(errors: 0);loopx canary premerge --from-git-diff --git-diff-base origin/main --tier quickPASS(含examples/pr-review-command-smoke.py、examples/value-connectors-github-public-probe-smoke.py、examples/issue-fix-workflow-contract-smoke.py全部通过)。
对主干的风险 / Risks
本 PR 不改动任何运行时代码、CLI 解析逻辑、状态机或 wait_for_ci=true 的独立默认策略,因此对未开启配置的 Goal 与线上运行无行为漂移风险。潜在文档误读风险在于读者可能把“允许 --admin”误解为跳过精确头评审或跳过本地校验;两份 skill 已明确限定 --admin 仅能覆盖作者自审 COMMENTED 阻断或未启用 CI 策略阻断,且必需的 check_rfc_bilingual.py、canary premerge、无未解线程与合并权限均不可绕过。另一项维护风险是 skills/loopx-pr-review/SKILL.md 已达 190 行上限(由 examples/pr-review-command-smoke.py 守护),后续若扩写需同步瘦身其它冗余措辞。所有触及界面均无 UI 渲染变更。
我的整体评价 / Verdict
改动精确命中根因(工作树缺少显式 --registry/--goal-id 导致 wait_for_ci 回退)、范围高度克制(仅 4 个文档与 skill 文件,零运行时入侵),并通过了 tests/test_workflow_skill_install.py(32 passed, 2 skipped)、公开边界检查(0 errors)与 loopx canary premerge --tier quick(含 examples/pr-review-command-smoke.py)。UI 视觉评审为 not_applicable(无渲染前端改动)。同意合入。
English verdict: APPROVE exact head 9040@dba7cae63d301c415f71c43fe33d7927d6ec23cf — docs and skill instructions strictly align local-first verification and Goal-bound wait_for_ci=false usage with existing contracts, and all quick premerge canaries and skill smoke checks pass.
Summary
wait_for_ci=false) delivery across developer workflow docs and PR skills (docs/development/README.md,docs/development/testing-and-quality.md,skills/loopx-pr-merge/SKILL.md,skills/loopx-pr-review/SKILL.md).loopx pr-reviewand--check-merge-readinessinvocations from worktrees or subagents must explicitly pass--registryand--goal-idsowait_for_ci=false(ci_policy="not_consulted") is preserved instead of silently falling back towait_for_ci=true.--match-head-commit HEAD_OID --admin(when branch protection holds only on author-ownedCOMMENTEDapprovals or unconsulted status checks) without polling asynchronous GitHub CI.Local Verification
dba7cae63d301c415f71c43fe33d7927d6ec23cfgit diff --check: PASSpytest -q --no-cov tests/test_workflow_skill_install.py: 32 passed, 2 skipped (Windows PowerShell cases on macOS)loopx --format json check --scan-path ...(4 edited files):ok: true, errors: 0loopx canary premerge --from-git-diff --git-diff-base origin/main --tier quick: passed (merge_gate_passed: true, includingexamples/pr-review-command-smoke.py)