Repository navigation
Conversation
Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com> Co-authored-by: TRAE CLI <traecli@bytedance.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved Explore findings already carry execution observations from the backend, but the chat reader strips them and the Lark summary omits them. This change preserves the existing typed observation through the saved-finding reader, reuses one disclosure component for results and research history, and includes actual execution facts in the existing Lark summary.
Readers can inspect the planned and actual method, change reason, elapsed time and limit, input/candidate revisions and result references. Missing measurements remain unknown. Findings without an observation retain their existing behavior. Observation readback does not certify adoption, benefit or acceptance.
保存的 Explore 结论原本已由后端返回执行观察,但聊天端解析会丢弃它,Lark 摘要也缺少实际执行信息。本变更复用现有类型校验与展示组件,使结论详情、研究历史和 Lark 摘要保留相同源事实;未知测量保持未知。双语 RFC 只增加此读回 checkpoint,整体机制重构仍为 Partial。
Validation
fa29e175f66c3421460c32320926096240f6f8d0; verified base:9dbe0f2a56077ed133d5bb3796bc2fa6df7d75a2onmain.interaction_contract.py::_admitted_interaction_next_cli_actions; the fixed base produces the same advisory. Bilingual RFC and public-boundary checks passed.Visual evidence / 视觉证据
Remaining author step: attach the inspected baseline/candidate screenshots to this description. The available browser connection is unavailable, so the attachments are not yet published and this proposal remains Draft.
The captured comparison uses the fixed base and exact candidate above, packaged UI assets, synthetic populated data (13 research events and 12 findings), disposable File/SQLite backends, and desktop/narrow viewports. The expanded result detail was inspected: unknown values remain explicit and long revisions wrap. This validates the packaged journey; installed-client behavior is untested. Reproduce using
node apps/presentation/dashboard/smoke/execution-feedback-browser-smoke.mjsafternpm run build:chatin the dashboard directory.剩余作者工作是把已检查的前后截图附到本段;浏览器附件通道当前不可用,尚未满足完整首屏证据门。实际打包界面与真实临时后端已验证,未声明已安装客户端验收。
Remaining mechanism work
Execution fusion and reader migration, actual method adoption, calibration, and independent outcome/full-cost qualification remain open in the mechanism RFC. This product-reader slice supports those existing routes without closing them. External benchmark execution is outside this slice.