Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 45 additions & 3 deletions examples/canary/catalog-planner-smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ def assert_profiles_come_from_catalog_matrix() -> None:
"todo-lifecycle",
"monitor-scheduler",
"state-write-correctness",
"issue-fix-reviewer-notification-drain",
"issue-fix-reviewer-routing",
"issue-fix-json-input-boundary",
"product-entry-workflows",
"cross-runtime-impl-review-demo",
"host-command-entry",
Expand Down Expand Up @@ -593,15 +596,54 @@ def assert_pr_release_and_refactor_profiles_select() -> None:
reviewer_profile = product_entry_profiles["issue-fix-reviewer-routing"]
reviewer_commands = [check["command"] for check in reviewer_profile["checks"]]
assert reviewer_commands == [
"python3 examples/issue-fix-json-input-boundary-smoke.py",
"python3 examples/issue-fix-capability-guide-smoke.py",
"python3 examples/issue-fix-reviewer-recommendation-smoke.py",
"python3 examples/issue-fix-reviewer-request-smoke.py",
"python3 examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py",
"python3 examples/issue-fix-reviewer-notification-sink-smoke.py",
], reviewer_profile
assert len(reviewer_commands) <= 3, reviewer_profile
assert all(check["tier"] == "default" for check in reviewer_profile["checks"]), reviewer_profile
assert reviewer_profile["deep_checks_available"] is False, reviewer_profile
assert "issue-fix-reviewer-notification-drain" not in product_entry_profiles, product_entry_payload

for trigger_file in (
"loopx/capabilities/issue_fix/reviewer_notification_drain.py",
"loopx/capabilities/issue_fix/reviewer_notification.py",
"examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py",
):
drain_payload = build_catalog_canary_plan(changed_files=[trigger_file])
drain_profiles = {
profile["id"]: profile for profile in drain_payload["domain_profiles"]
}
assert "issue-fix-reviewer-notification-drain" in drain_profiles, (
trigger_file,
drain_payload,
)
assert "issue-fix-reviewer-routing" not in drain_profiles, (
trigger_file,
drain_payload,
)
drain_profile = drain_profiles["issue-fix-reviewer-notification-drain"]
drain_commands = [check["command"] for check in drain_profile["checks"]]
assert drain_commands == [
"python3 examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py",
"python3 examples/issue-fix-reviewer-notification-sink-smoke.py",
], drain_profile
assert len(drain_commands) <= 3, drain_profile
assert "python3 examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py" in (
drain_payload["commands"]
), drain_payload

json_boundary_payload = build_catalog_canary_plan(
changed_files=["loopx/capabilities/issue_fix/cli.py"]
)
json_boundary_profiles = {
profile["id"]: profile for profile in json_boundary_payload["domain_profiles"]
}
assert "issue-fix-json-input-boundary" in json_boundary_profiles, json_boundary_payload
assert [
check["command"]
for check in json_boundary_profiles["issue-fix-json-input-boundary"]["checks"]
] == ["python3 examples/issue-fix-json-input-boundary-smoke.py"]

outcome_payload = build_catalog_canary_plan(
changed_files=[
Expand Down
168 changes: 104 additions & 64 deletions loopx/canary/planner.py
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,110 @@
},
],
},
{
"id": "issue-fix-reviewer-notification-drain",
"title": "Issue-fix reviewer notification drain and sinks",
"purpose": (
"Check restart-safe reviewer notification queue draining, post-write "
"suppression, semantic history dedupe, and project-dedicated secondary "
"sink boundaries."
),
"catalog_families": ["Human Decision", "Evidence Lifecycle", "State And Boundary"],
"trigger_hints": (
"reviewer notification drain",
"reviewer-notification-drain",
"reviewer notification sink",
"reviewer-notification-sink",
"issue_fix_reviewer_notification",
"issue-fix-reviewer-notification",
"loopx/capabilities/issue_fix/reviewer_notification_drain.py",
"loopx/capabilities/issue_fix/reviewer_notification.py",
"loopx/capabilities/issue_fix/reviewer_cli.py",
"loopx/extensions/lark/reviewer_notification.py",
"loopx/capabilities/issue_fix/docs/protocols/issue-fix-reviewer-notification-sinks-v0.md",
"examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py",
"examples/issue-fix-reviewer-notification-sink-smoke.py",
"tests/capabilities/test_issue_fix_reviewer_notification_drain.py",
),
"checks": [
{
"command": "python3 examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py",
"tier": "default",
"reason": "guards restart-safe drain writeback, unverified-send suppression, and semantic notification deduplication",
},
{
"command": "python3 examples/issue-fix-reviewer-notification-sink-smoke.py",
"tier": "default",
"reason": "guards project-dedicated secondary notification identity, local-private mapping, idempotent send/readback, concrete gates, and public-safety redaction",
},
],
},
{
"id": "issue-fix-reviewer-routing",
"title": "Issue-fix reviewer routing and bilingual guide",
"purpose": (
"Check the bilingual issue-fix product entry and explainable local "
"reviewer recommendation plus authority-gated GitHub reviewer request "
"contract."
),
"catalog_families": ["Human Decision", "Evidence Lifecycle", "State And Boundary"],
"trigger_hints": (
"reviewer-plan",
"reviewer recommendation",
"issue_fix_reviewer_recommendation",
"reviewer-request",
"issue_fix_reviewer_request",
"loopx/capabilities/issue_fix/README",
"loopx/capabilities/issue_fix/docs/protocols/issue-fix-reviewer-recommendation",
"loopx/capabilities/issue_fix/docs/protocols/issue-fix-reviewer-request",
"examples/issue-fix-capability-guide-smoke.py",
"examples/issue-fix-reviewer-recommendation-smoke.py",
"examples/issue-fix-reviewer-request-smoke.py",
"loopx/capabilities/issue_fix/reviewer_cli.py",
"loopx/capabilities/issue_fix/reviewer_recommendation.py",
"loopx/capabilities/issue_fix/reviewer_request.py",
),
"checks": [
{
"command": "python3 examples/issue-fix-capability-guide-smoke.py",
"tier": "default",
"reason": "guards the bilingual issue-fix product entry, README links, reviewer protocol, and public-safe roadmap surface",
},
{
"command": "python3 examples/issue-fix-reviewer-recommendation-smoke.py",
"tier": "default",
"reason": "guards explainable CODEOWNERS and base-revision changed-path/module-history reviewer recommendations",
},
{
"command": "python3 examples/issue-fix-reviewer-request-smoke.py",
"tier": "default",
"reason": "guards author exclusion, formal-request-first notification, permission-only comment fallback, idempotency, blockers, and post-write verification",
},
],
},
{
"id": "issue-fix-json-input-boundary",
"title": "Issue-fix JSON input boundary",
"purpose": (
"Check bounded inline issue-fix JSON inputs and compact errors that "
"never echo raw payloads."
),
"catalog_families": ["State And Boundary"],
"trigger_hints": (
"json-input-boundary",
"issue-fix-json-input-boundary",
"loopx/capabilities/issue_fix/cli.py",
"loopx/capabilities/issue_fix/cli_input.py",
"examples/issue-fix-json-input-boundary-smoke.py",
),
"checks": [
{
"command": "python3 examples/issue-fix-json-input-boundary-smoke.py",
"tier": "default",
"reason": "guards bounded inline issue-fix JSON inputs and compact errors that never echo raw payloads",
},
],
},
{
"id": "product-entry-workflows",
"title": "Product entry workflows",
Expand Down Expand Up @@ -744,70 +848,6 @@
},
],
},
{
"id": "issue-fix-reviewer-routing",
"title": "Issue-fix reviewer routing and bilingual guide",
"purpose": (
"Check the bilingual issue-fix product entry and explainable local "
"reviewer recommendation plus authority-gated verified notification "
"contract."
),
"catalog_families": ["Human Decision", "Evidence Lifecycle", "State And Boundary"],
"trigger_hints": (
"reviewer-plan",
"reviewer recommendation",
"issue_fix_reviewer_recommendation",
"reviewer-request",
"issue_fix_reviewer_request",
"reviewer notification sink",
"issue_fix_reviewer_notification",
"loopx/capabilities/issue_fix/README",
"loopx/capabilities/issue_fix/docs/protocols/issue-fix-reviewer-recommendation",
"examples/issue-fix-capability-guide-smoke.py",
"examples/issue-fix-reviewer-recommendation-smoke.py",
"examples/issue-fix-reviewer-request-smoke.py",
"examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py",
"loopx/capabilities/issue_fix/reviewer_notification_drain.py",
"examples/issue-fix-json-input-boundary-smoke.py",
"examples/issue-fix-reviewer-notification-sink-smoke.py",
"loopx/capabilities/issue_fix/cli.py",
"loopx/capabilities/issue_fix/reviewer_recommendation.py",
"loopx/capabilities/issue_fix/reviewer_request.py",
"loopx/capabilities/issue_fix/reviewer_notification.py",
),
"checks": [
{
"command": "python3 examples/issue-fix-json-input-boundary-smoke.py",
"tier": "default",
"reason": "guards bounded inline issue-fix JSON inputs and compact errors that never echo raw payloads",
},
{
"command": "python3 examples/issue-fix-capability-guide-smoke.py",
"tier": "default",
"reason": "guards the bilingual issue-fix product entry, README links, reviewer protocol, and public-safe roadmap surface",
},
{
"command": "python3 examples/issue-fix-reviewer-recommendation-smoke.py",
"tier": "default",
"reason": "guards explainable CODEOWNERS and base-revision changed-path/module-history reviewer recommendations",
},
{
"command": "python3 examples/issue-fix-reviewer-request-smoke.py",
"tier": "default",
"reason": "guards author exclusion, formal-request-first notification, permission-only comment fallback, idempotency, blockers, and post-write verification",
},
{
"command": "python3 examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py",
"tier": "default",
"reason": "guards restart-safe drain writeback, unverified-send suppression, and semantic notification deduplication",
},
{
"command": "python3 examples/issue-fix-reviewer-notification-sink-smoke.py",
"tier": "default",
"reason": "guards project-dedicated secondary notification identity, local-private mapping, idempotent send/readback, concrete gates, and public-safety redaction",
},
],
},
{
"id": "issue-fix-outcome-visibility",
"title": "Issue-fix status and output visibility",
Expand Down
94 changes: 94 additions & 0 deletions tests/canary/test_issue_fix_drain_canary_selection.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
from __future__ import annotations

from loopx.canary.planner import build_catalog_canary_plan
from loopx.canary.premerge import build_premerge_validation_gate
from loopx.canary.runner import build_canary_smoke_suite_run


def test_reviewer_notification_drain_change_selects_postwrite_smoke_under_premerge_and_smoke_suite() -> None:
changed = ["loopx/capabilities/issue_fix/reviewer_notification_drain.py"]

quick_gate = build_premerge_validation_gate(
changed_files=changed,
tier="quick",
execute=False,
)
quick_commands = [
check["command"]
for check in quick_gate["catalog_run"]["selected_checks"]
]
assert (
"python3 examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py"
in quick_commands
), quick_commands

standard_gate = build_premerge_validation_gate(
changed_files=changed,
tier="standard",
execute=False,
)
standard_commands = [
check["command"]
for check in standard_gate["catalog_run"]["selected_checks"]
]
assert (
"python3 examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py"
in standard_commands
), standard_commands
assert (
"python3 examples/issue-fix-reviewer-notification-sink-smoke.py"
in standard_commands
), standard_commands

limited_suite = build_canary_smoke_suite_run(
suite="catalog-plan",
changed_files=changed,
limit=3,
execute=False,
)
limited_commands = [
check["command"] for check in limited_suite["selected_checks"]
]
assert (
"python3 examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py"
in limited_commands
), limited_commands

profile_suite = build_canary_smoke_suite_run(
suite="catalog-plan",
profiles=["issue-fix-reviewer-notification-drain"],
execute=False,
)
profile_commands = [
check["command"] for check in profile_suite["selected_checks"]
]
assert profile_commands == [
"python3 examples/issue-fix-reviewer-notification-drain-postwrite-smoke.py",
"python3 examples/issue-fix-reviewer-notification-sink-smoke.py",
]


def test_reviewer_routing_profile_stays_within_three_checks_and_avoids_drain_drift() -> None:
routing_suite = build_canary_smoke_suite_run(
suite="catalog-plan",
profiles=["issue-fix-reviewer-routing"],
execute=False,
)
routing_commands = [
check["command"] for check in routing_suite["selected_checks"]
]
assert routing_commands == [
"python3 examples/issue-fix-capability-guide-smoke.py",
"python3 examples/issue-fix-reviewer-recommendation-smoke.py",
"python3 examples/issue-fix-reviewer-request-smoke.py",
]

unrelated_plan = build_catalog_canary_plan(
changed_files=["loopx/capabilities/issue_fix/workflow_plan.py"]
)
unrelated_ids = {
profile["id"] for profile in unrelated_plan["domain_profiles"]
}
assert "issue-fix-reviewer-notification-drain" not in unrelated_ids
assert "issue-fix-reviewer-routing" not in unrelated_ids
assert "issue-fix-json-input-boundary" not in unrelated_ids
Loading
Loading