Repository navigation
feat(steward): add isolated OpenViking long-term memory with per-speaker boundaries - #9083
Conversation
…ker boundaries Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · Gemini · Google · self_reported
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机 / Motivation
评审精确 head 4cbd4d62cd0cc62924071444b33bf9ec26b38ee3。受影响主体为使用绑定私聊与 LoopX 个人管家持续协作的个人所有者,以及管理本机管家记忆开关、命名空间和召回超时上限的桌面与移动端操作者。此前个人私聊管家每次新开会话或压缩上下文后缺少跨会话偏好与历史事件记忆,且缺少独立身份与受众隔离边界;本改动在关闭时保持基线完全不变,开启后由 TypeScript 控制面按绑定关系与已验证发言人推导隔离路径并规范化可选偏好写入,Python 适配器以临时 0600 配置、10 分钟缓存与超时放行保护正常私聊回复,并在子工作进程中剔除 OPENVIKING_* 环境变量。可观测结果为:设置页“管家”分类新增默认关闭的“独立 OpenViking 长期记忆”能力(支持 en 与 zh-CN 双语及紧凑受众隔离提示);仅在本人私聊管家正式回合注入召回上下文并支持经核心白名单校验的 memory_preferences 写入,群聊、项目对话、内部巡检与评审回合均被拒绝且 OpenViking 不可用或超时不会阻塞私聊回复。本 PR 不在公开仓库中捆绑本地服务凭据、不向群聊或工作 Agent 开放管家记忆、不默认开启跨会话记忆,也不修改非管家能力的既有上下文或配置行为。
改动思路 / Approach
架构定位与边界:复用既有 TypeScript effect_runtime、machine_configuration 单一所有者与配置 UI 渲染体系,在控制面集中裁决受众隔离与白名单路径,未在 Python 侧复制策略拥有者或向子工作环境透传凭据。仅提供默认关闭、仅限本人私聊管家的独立 OpenViking 命名空间、有界故障放行召回、白名单偏好写入与工作进程环境清理;不包含群聊多 Agent 共享记忆或自动化后台同步循环。
- TypeScript 控制面受众隔离与白名单归属:
loopx/control_plane/collaboration/steward_memory.ts注册collaboration.steward.memory_policy与collaboration.steward.memory_preferences,硬性校验证实私聊bound_steward受众、排除群聊/项目/监控/评审/机器人发言,并按 SHA-256 哈希推导出owner与<segment>~<12hex>目录、阻断模型伪造speaker/uri等目标字段(使用EffectRuntimeRequestError)。 - Python 有界适配器与子工作进程隔离:
loopx/capabilities/steward_memory/runtime.py以临时0600CLI 配置、10 分钟发言人缓存(写入即失效)、只写向量事件以及超时故障放行实现recall_steward_memory_for_turn与commit_steward_memory_after_turn,并在codex_context.process_environment清空OPENVIKING_*环境变量防止泄漏给项目工作 Agent。 - 单源机器配置与桌面/移动端设置界面:在
machine_configuration/builtins.py与configuration_ui.py注册默认关闭的steward_memory,并在个人工作区设置“管家”分类补充en/zh-CN双语说明与紧凑受众隔离提示,完整通过ego-browser桌面1280x800与窄屏390x844默认/展开态实机审阅。
具体改动 / Changes
loopx/control_plane/collaboration/steward_memory.ts&effect_runtime_handlers.ts: 新增单源策略与偏好归一化处理器,强制私聊与发言人边界隔离。loopx/capabilities/steward_memory/{__init__,machine_defaults,runtime}.py: 新增默认关闭配置结构、有界召回/提交运行时、OPENVIKING_*环境清理及子目录路径校验。loopx/capabilities/{machine_configuration/builtins,configuration_ui}.py&native_chat/{codex_context,external_conversations}.py&chat.py,chat/coordination.py,chat_runtime.py: 完成机器配置注册、回答响应规范化、评审回合拦截、协调上下文注入、事件记录及非隔离工作环境清理。apps/presentation/dashboard/src/features/personal-workspace/{capability-localization.ts,machine-configuration-settings.tsx}: 接入管家分类卡片、中英文描述与紧凑提示(含各能力独立的enabled字段中文说明)。tests/{control_plane_ts/steward_memory.test.ts,test_steward_openviking_memory.py,capabilities/...,test_chat_machine_configuration_api.py}&personal-workspace-contract.test.mjs: 补充策略拒绝、缓存失效、超时放行、环境清理及 UI/API 清单全覆盖单测。
对主干的风险 / Risks
低风险(已在本地精确 head 通过全量验证):
ruff check对修改与新增 Python 文件零告警;- Node TypeScript 契约与政策单测
8/8通过,Dashboard Vite + Chat 打包退出码0; pytest(test_steward_openviking_memory.py及机器配置、UI、API、响应解析、原生管家回归)306 passed;control-plane-maintainability-ratchet-smoke.py(unreviewed=0)、semantic-vocabulary-drift-smoke.py及canary premerge --from-git-diff --git-diff-base origin/main15/15全通过;- 默认
enabled=false时全部现有对话与工作 Agent 行为完全保持不变。
我的整体评价 / Verdict
本 PR 为个人管家补齐了按绑定身份和已验证发言人隔离的 OpenViking 长期记忆基础设施,策略边界由 TypeScript 控制面集中拥有,读取超时安全降级且不向群聊或代码工作进程泄漏凭据或跨会话状态。已在隔离预览服务中通过 ego-browser 检查打包后的设置页“管家 -> 独立 OpenViking 长期记忆”界面(zh-CN 与 en,桌面 1280x800 与窄屏 390x844 的默认折叠及展开配置说明/原始 JSON 状态),主开关、输入框、紧凑受众隔离提示与操作按钮层级清晰,中文字段说明完整且无横向溢出。设置变更在线上真实守护进程启用并与真实 OpenViking 实例联动读写的结果留待本地发行升级后端到端核验。
English Verdict: APPROVE - Verified at exact head 4cbd4d6; isolated steward_memory TS policy, fail-open bounded Python runtime, worker env scrubbing, Dashboard Settings UI visual inspection across desktop/narrow viewports (zh-CN & en), and all ruff, Node (8/8), Python (306), ratchet, vocabulary, and premerge (15/15) checks pass.
Summary
Add opt-in, default-off isolated OpenViking long-term memory (
steward_memory) for owner private steward conversations, enforcing core-owned audience and speaker isolation without exposing group chats, project conversations, or peer worker environments to private steward memory:loopx/control_plane/collaboration/steward_memory.ts, registered ineffect_runtime_handlers.ts):planStewardMemoryTurn(collaboration.steward.memory_policy): enforcesenabledopt-in,external_audience+bound_steward+private_conversationchecks, rejects project conversations, monitor/report turns, answer/metadata reviews, bots/apps, and unverified senders (sender_unverified).ownervs collision-safe<segment>~<12hex>per-speaker directories andsteward-<binding_id>peer URI (viking://user/<user_space>/peers/<actor_peer_id>/memories/...).normalizeStewardMemoryPreferences(collaboration.steward.memory_preferences): rejects model-authored routing/target overrides (speaker,owner,uri,user_space,peer_id,operator_ref,binding_id,target,sender_id,directory), validatesupsert/remove, slugifies topics, and enforces size/op limits (EffectRuntimeRequestErroron invalid input).loopx/capabilities/steward_memory/):steward_memorymachine configuration namespace (steward_memory_machine_defaults_v0, registered inmachine_configuration/builtins.py&configuration_ui.py).recall_steward_memory_for_turn/commit_steward_memory_after_turn: uses ephemeral0600temp CLI configs, 10-minute per-speaker preference cache (invalidated on commit),vectors_onlywrites, and bounded recall deadlines failing open (not_configured/timeout/unavailable).scrub_openviking_environmentwired intocodex_context.process_environment(not isolated) so child worker processes never inheritOPENVIKING_*steward credentials.chat/coordination.py,chat.py(optional"memory_preferences"normalization),external_conversations.py(blocked fromanswer_review/metadata_review), andchat_runtime.py.apps/presentation/dashboard/src/features/personal-workspace/):steward_memoryin theStewardmachine settings category with localizeden&zh-CNlabels/help text (including per-capabilityenabledfield description) and a compact audience-isolation indicator.Visual Evidence / 首屏与响应式审阅证据
4cbd4d62cd0cc62924071444b33bf9ec26b38ee3using the builtloopx/web/chatproduction chat bundle (npm --prefix apps/presentation/dashboard run build) served from an isolated loopback disposable preview server (loopx chat --no-open) inego-browser.1280x800,zh-CN&en) — Default & Expanded:Settings -> Steward -> Isolated OpenViking memory(设置 -> 管家 -> 独立 OpenViking 长期记忆) renders cleanly at full width (scrollWidth == 1280 == innerWidth), presenting primary fields (Enabled,User space,Auto recall history,Recall timeout (seconds)) abovePreview changes/Apply reviewed previewwithout inline prose clutter.Owner private chats only/仅限本人私聊与独立身份) communicates the boundary, whileConfiguration help(配置说明) andAdvanced: raw JSON(高级:原始 JSON) collapse by default and expand cleanly on demand with localizedzh-CN/enfield descriptions.390x844,zh-CN&en) — Default & Expanded:scrollWidth == 390 == innerWidth) in both default and expanded states.Verification
uv run --extra test ruff check ...— passed (All checks passed!)node --experimental-strip-types --test tests/control_plane_ts/steward_memory.test.ts apps/presentation/dashboard/src/features/personal-workspace/personal-workspace-contract.test.mjs—8/8passedPYTHONPATH=tests uv run --extra test python -m pytest -n 6 tests/test_steward_openviking_memory.py tests/capabilities/test_machine_configuration_contract.py tests/capabilities/test_capability_configuration_ui.py tests/test_chat_machine_configuration_api.py tests/test_chat_response_parsing.py tests/test_native_steward_runtime.py tests/test_antigravity_steward_adapter.py -q—306 passednpm --prefix apps/presentation/dashboard run build(tsc --noEmit && vite build && npm run build:chat) — exited0uv run --extra test python examples/control_plane/control-plane-maintainability-ratchet-smoke.py— passed (unreviewed: 0)uv run --extra test python examples/semantic-vocabulary-drift-smoke.py(--diff-base origin/main& full) — passeduv run --extra test loopx --format json canary premerge --from-git-diff --git-diff-base origin/main— passed (selected=15,failures=0)