Repository navigation
Test C1 planning and Host input from the original quota capture - #9102
loopx-agent wants to merge 2 commits into
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, max)
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机 / Motivation
维护 quota、Turn 和 Codex CLI 的开发者。 当前 quota CLI 写出 complete v1 capture。主干两项测试在签名后改路径,另四项从 v0 接口读取 v1,均在核对原始义务前失败。 实际 File/SQLite quota CLI 保存原始决定,无 Todo 规划沿用原 settlement identity。Codex CLI prompt 读回独立给定的任务全文、附注与 Goal 验收条款。 恢复现有测试对实际 C1 producer、planner 和 Host prompt 的覆盖。两个变更文件均为测试,生产代码保持原样。 安装后的生产 Host、实际模型对义务的采用和 C1 同预算成果/完整成本仍待独立验收。 C1 验收依据
改动思路 / Approach
无 Todo 用例让 quota CLI 在准入时写原文件,再由生产 Turn planner 读同一份决定。任务与 Goal 用例事先写入独立的正文、附注和验收条款,生成实际 Codex CLI prompt 后逐项核对。显式构造历史 envelope,复用其绑定和版本拒绝路径。 原捕获 Host 回读
具体改动 / Changes
精确 head 1cf44a765cb3b7d7baae834d0110778544f3920d,base 8e9a28a866da06cc6fd63e78709910fe35dad564,两个测试文件新增 47 行、删除 23 行。File 和 SQLite 各覆盖一组无 Todo 规划和两组长短任务输入。原始结算身份通过同一 capture 字节核对。编写的义务到达 Host,包括任务全文、附注和 Goal 条款。安装与成本验收仍属 C1 后续。拒绝不支持的载体经过真实 turn run-once 在 Host 启动之前拒绝。 拒绝用例
对主干的风险 / Risks
两份变更模块和独立 stateless replan 用例共 36 项通过。变更 Ruff、预合并 5 项直接检查和 3 项 smoke 通过。原来六项在 base 失败、head 通过。下列三组用相同命令在两树各失败两个 provider 用例。
- Goal availability 的显式 Off 会携带完整内联 Goal,长短 fixture 导致 channel 不同。 失败点
- bound-replan Host 的现有用例仍要求 v0,实际 CLI 发出 v1。 失败点
- captured-replan memory 的现有用例替换
replan_read_path后预期保留投影,实际得到空投影。 失败点
三个失败文件和生产实现都保持原样。安装后的生产 Host、实际模型对义务的采用和 C1 同预算成果/完整成本仍待独立验收。
我的整体评价 / Verdict
同意此精确提交。实际 File/SQLite quota CLI 保存原始决定,无 Todo 规划沿用原 settlement identity。Codex CLI prompt 读回独立给定的任务全文、附注与 Goal 验收条款。 历史适配拒绝缺失或未来版本及绑定错误。真实 turn run-once 的拒绝用例没有启动 fixture Host,也没有新增扣额。 当前检查覆盖实际 CLI 与 prompt builder,Host launch probe 使用隔离 fixture。
English verdict: APPROVE. The original signed capture now exercises planning identity, authored work in the Codex CLI prompt, and historical refusal. The six adjacent failures are identical on the base and head.
Goal and delivered outcome
Verify that quota admission, Turn planning and Codex model input all use the same signed C1 capture. Six File/SQLite cases on
mainfailed before reaching their intended assertions. Two no-Todo cases rewrote the capture path after signing. Four authored-context cases decoded the active CLI output as v0.The no-Todo fixture now asks the quota CLI to write the capture during admission and checks the original settlement identity in the production Turn planner. The authored-context cases carry the captured source through the production Host request and Codex CLI prompt, checking the original task, its note and the complete Goal text. Existing binding and version rejection cases exercise the explicit historical adapter. Source composition and capture
Validation
8e9a28a866da06cc6fd63e78709910fe35dad564reproduced six failures across the two changed modules. Head1cf44a765cb3b7d7baae834d0110778544f3920dpassed both full modules plus the dedicated captured replan cases, 36 tests in total.--context-delivery offand declared Codex App entrypoints on File and SQLite. All produced a signed C1 source with the original admission identity and zero debits. Ordinary and App delivery paginated that source. Explicit Off returned the complete source inline.Scope
Test-only coverage. The separate Goal availability cases still fail on base and head because the generic Off route inlines the full Goal, including the long fixture. The separate bound-replan Host cases still expect v0 in both trees. Installed release coverage, historical reader retirement and the matched single-session outcome and full-cost comparison remain open.
UI impact
none. Fixtures use synthetic File and SQLite state. Written by OpenAI Codex. C1 validation and acceptance