Conversation
chore: release 1.0.0
The image was built by `release.yml` and nowhere else, so a change that broke the Dockerfile was found by the release that was meant to publish it -- at the one moment when the fix costs a second tag. This asks the same question on every push to `main` and on every pull request aiming at it, which is where a release goes through. Build only. Nothing is pushed and nothing logs in: the question is whether the image builds, not whether the branch can publish, and a job needing credentials could not run on a fork. One platform, the runner's own, because the other means QEMU and turns a two-minute compile into most of an hour -- the release builds each natively and stages the binaries, which is a different path and is checked by the release itself. From source with nothing staged, which is the branch a developer hits with `docker build .` on a checkout: the compile *and* the dashboard build happen inside the image, and the release never runs that. `lfs: true`, because `assets/favicon.ico` is an LFS object the frontend's prebuild copies -- without it vite ships a pointer file as the favicon. Cached through `type=gha`, or every push to main pays for a release-profile compile of the whole workspace. No CHANGES.md entry: this changes nothing an operator or a client can observe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated back-merge of
mainintodevelop.Latest commit on main:
244d8f7-- Merge pull request #10 from lorem-dev/developOpened by
Back-merge main -> develop, run31651935950.Merge this (or turn on auto-merge) to keep
developin step withmain. Resolve any conflicts here rather than on develop.