Conversation
chore: release 1.1.0
A tag is a claim about a commit, and nothing verified the claim before the build acted on it. v1.1.0 was pushed at a 1.0.0 tree -- the release pull request was still open -- and the image job published that build under 1.1.0-alpine, 1.1-alpine and 1-alpine, and rewrote the Docker Hub overview to name it. The release notes step caught it twenty minutes later, after the damage was on the hub. The new `verify` job checks the three things a release cannot be wrong about before anything is built: the workspace version equals the tag, CHANGES.md has a non-empty section for it, and a final tag is on `main`. Every other job descends from `frontend`, so gating that one gates all of them. The branch rule was already documented in CONTRIBUTING.md and AGENTS.md as something this workflow enforced. It was not. Now it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated back-merge of
mainintodevelop.Latest commit on main:
783adaf-- Merge pull request #14 from lorem-dev/developOpened by
Back-merge main -> develop, run32002563989.Merge this (or turn on auto-merge) to keep
developin step withmain. Resolve any conflicts here rather than on develop.