Conversation
The workflow's first run failed with "GitHub Actions is not permitted to create or approve pull requests". That is a repository setting, off by default, and no amount of `permissions:` in the workflow grants it -- so it belongs written down next to the branch rules rather than rediscovered.
`a_genuine_upstream_failure_is_logged_at_warn_not_info` failed on CI for v0.1.0 with "expected exactly one log line, got []". The harness set a capture subscriber as the thread-local default, on the stated reasoning that thread-local state is invisible to other tests. The state that matters is not thread-local: `tracing` caches each callsite's `Interest` in a process-wide table, computed the first time the callsite is hit, and when a single dispatcher is alive `tracing-core` computes it by asking the *registering thread's* default subscriber. The thread that first reaches the `warn!` in `handle` is usually one running an ordinary `send`, whose default is `NoSubscriber` -- which answers `Interest::never()` and disables the callsite for every thread. Replaced with one subscriber for the test binary, installed once, whose `enabled` is unconditionally true, routing events to a per-thread sink. Whichever thread registers a callsite now gets the same answer; target filtering moved into `event`, which is not cached. Measured on the built test binary at `--test-threads=6`, 300 runs each: 20 failures before, 0 after. Mutating the level from WARN to INFO still fails the test.
The publish job downloaded every artifact in the run, not just the `doppel-*` archives. That includes the two `docker-*` musl binaries built for the image, both named plain `doppel`, so `merge-multiple` collapsed them onto each other and `gh release create dist/*` attached the survivor as a bare `doppel` of unstated architecture. v0.1.0 shipped with exactly that asset next to the three tarballs. `pattern: doppel-*` leaves the musl binaries where they are. The comment in the musl job claimed the artifact namespace already did this; it did not, because the glob it described was never written.
Two badges pointed at the documentation -- the site and the workflow that builds it -- and none at releases or coverage. Replaced the workflow badge with a release badge and a coverage badge, in the order skillkeeper uses: download, docs, licence, coverage, CI. Coverage is line coverage over the workspace with the test database up, measured with `cargo llvm-cov --workspace --summary-only`: 92.64%. Without a database it reads 83%, because the PostgreSQL store's tests skip themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated back-merge of
mainintodevelop.Latest commit on main:
b4507f1-- docs: record the setting the back-merge workflow needsOpened by
Back-merge main -> develop, run30762708328.Merge this (or turn on auto-merge) to keep
developin step withmain. Resolve any conflicts here rather than on develop.