Repository navigation
DM-53944: Improve handling of job environment settings. - #231
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 92.76% 93.30% +0.53%
==========================================
Files 53 53
Lines 6459 6632 +173
Branches 571 586 +15
==========================================
+ Hits 5992 6188 +196
+ Misses 367 352 -15
+ Partials 100 92 -8 ☔ View full report in Codecov by Harness. |
MichelleGower
force-pushed
the
tickets/DM-53944
branch
4 times, most recently
from
October 3, 2026 20:03
2b28dad to
d0f4959
Compare
MichelleGower
force-pushed
the
tickets/DM-53944
branch
from
October 10, 2026 00:44
d0f4959 to
1894d5e
Compare
MichelleGower
marked this pull request as ready for review
October 12, 2026 18:49
MichelleGower
force-pushed
the
tickets/DM-53944
branch
from
October 14, 2026 17:49
f09c113 to
2877544
Compare
mxk62
approved these changes
Oct 14, 2026
Read submit configs through a private Config subclass whose merge
replaces ${VAR} inside environment sections with the value already
held for VAR. Several included files can then each prepend to the
same environment variable, whatever it is called, without any
special handling in daf_butler.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
MichelleGower
force-pushed
the
tickets/DM-53944
branch
from
October 15, 2026 16:49
2877544 to
6b4421b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes