Repository navigation
DM-53098 : Convert ctrl_bps_htcondor to use htcondor2 - #101
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 88.41% 88.19% -0.22%
==========================================
Files 21 23 +2
Lines 5067 5059 -8
Branches 504 502 -2
==========================================
- Hits 4480 4462 -18
- Misses 499 510 +11
+ Partials 88 87 -1 ☔ View full report in Codecov by Harness. |
tcjennings
force-pushed
the
tickets/DM-53098
branch
4 times, most recently
from
August 20, 2026 21:23
dafde1d to
57ad5ae
Compare
tcjennings
force-pushed
the
tickets/DM-53098
branch
2 times, most recently
from
September 3, 2026 15:38
3606836 to
89678b5
Compare
tcjennings
changed the title
tcjennings
force-pushed
the
tickets/DM-53098
branch
2 times, most recently
from
September 11, 2026 15:59
9a23aae to
5bc5233
Compare
tcjennings
marked this pull request as ready for review
September 11, 2026 16:01
Contributor
Author
|
This PR will require a repository admin to change the configuration for "required status checks" in branch protection to require only the bare |
tcjennings
force-pushed
the
tickets/DM-53098
branch
3 times, most recently
from
September 11, 2026 16:24
c4342bc to
c32d8bc
Compare
tcjennings
force-pushed
the
tickets/DM-53098
branch
4 times, most recently
from
September 14, 2026 19:07
f3d702f to
dc368ac
Compare
mxk62
approved these changes
Sep 21, 2026
| raise HTCondorException("Unable to locate daemon.") from e | ||
| except HTCondorIOError as e: | ||
| raise HTCondorException("Unable to connect to daemon.") from e | ||
| secman = None |
Collaborator
There was a problem hiding this comment.
Why do we need this assignment here? Seems necessary.
Contributor
Author
There was a problem hiding this comment.
What's intended here is to clear any references to objects in the legacy htcondor module and "unload" the module, but this is probably better done with del statements.
tcjennings
force-pushed
the
tickets/DM-53098
branch
6 times, most recently
from
October 1, 2026 18:23
144ed13 to
68c585d
Compare
- use `htcondor2` imports instead of `htcondor` - correct patch objects in tests - refactor `htcondor2`-induced changes - log htcondor package version in wms service prepare
- write a fake ToE for events. - mark ToE-related classes deprecated - removes deprecated JobStatus enum in favor of `htcondor.JobStatus` - update dagman configuration model
- for htcondor 24.0 LTS, use the old ping API
- pin htcondor to 24|25 - add matrix test for htcondor versions - add towncrier fragment - move to uv - update github actions
- run ci tests in a python/htcondor matrix
- reduce `JobCompleted*Handler` classes to a single `JobCompletedHandler` - remove ToE generation and expectation code - improve type handling in handler tests - import specific objects from `classad2` - incidental docstring and typing improvement
- add an explicit "queue 1" to Submit ads when using `htcondor==24.0.*` - use `itemdata=None` when submitting to a Schedd.
- improve docstrings - clean up object references in legacy ping with `del` - improve exception catching - bump codeql action to 4.38.2 - rebase against main and migrate new work to `htcondor2`
tcjennings
force-pushed
the
tickets/DM-53098
branch
from
October 8, 2026 17:05
68c585d to
541434d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
htcondor->htcondor2for HTCondor Python bindings 24.0.x (LTS) and beyond.Supports both 24.0.x and 25.0.x LTS client packages. (closes #71)
For 24.0.x only, the legacy
SecMan.pingmethod is used. In 24.x and beyond,SecManis deprecated and removed. Thepingfunction has been added to the module level (htcondor2.ping) except in 24.0.x.Because
htcondor2job events do not read or parse a "Toe" tag from event entries, theJobCompletedhandlers have been refactored into a single class definition to support the new Job Event ClassAd standard.Migrates project management to
uv. Updates GHA workflows foruvand security (closes #107) (closes #18).Todo
Checklist
doc/changes