Repository navigation
DM-56308: updated DP2 NB 306 1 and new 306 2 (extragal transients) - #220
MelissaGraham wants to merge 1 commit into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -22,7 +22,7 @@ | |||
| "Data Release: [Data Preview 2](https://dp2.lsst.io/)\\\n", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Note to self: emphasize that fluxes should be used with difference-image measurements (do it in boldface like the other important points).
| @@ -22,7 +22,7 @@ | |||
| "Data Release: [Data Preview 2](https://dp2.lsst.io/)\\\n", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Note to self: specify this is not nearest-neighbor, this will return all sources within the radius so multiple matches are possible. It's why the 2" gets used here, to demonstrate this, so make it clearer for the user.
| @@ -22,7 +22,7 @@ | |||
| "Data Release: [Data Preview 2](https://dp2.lsst.io/)\\\n", | |||
There was a problem hiding this comment.
Perhaps mention that the cases when flux <=0 can be filtered out from the analysis, if the magnitude is needed (from forced photometry on the science image).
Reply via ReviewNB
There was a problem hiding this comment.
Note to self: mention again that in the future, with no template contamination, transient fluxes should all be >0 in the difference image, and so being careful to retain flux<0 data points is a DP2-specific issue, because of how templates are made.
| @@ -0,0 +1,790 @@ | |||
| { | |||
There was a problem hiding this comment.
Perhaps a bit more description here for clarification. For example, later the code uses "new_cmap = truncate_colormap(orig_cmap, 0.2, 0.7)". Would values "<0.2" or ">0.7" be presented/omitted? I think those colors are not used (i.e. no darkest or lightest colors in the original map will be used). But there is no truncation on the value range (sp.draw_hpxbin count) to be presented.
Reply via ReviewNB
| @@ -0,0 +1,790 @@ | |||
| { | |||
There was a problem hiding this comment.
shenmingfu
left a comment
shenmingfu
left a comment
There was a problem hiding this comment.
It looks great! Thank you. I left some comments. I will approve the PR.
2 participants
No description provided.