[WRONG BRANCH] fix(windows): remove native WinSW service during fresh scheduler install - #265
[WRONG BRANCH] fix(windows): remove native WinSW service during fresh scheduler install#265luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
Description
removeNativeWindowsServiceForScheduler()and reuse it from the existing native installer path.removeNativeServicetest seam toFreshWindowsSchedulerInstallDepsand updated unit tests to assert the new ordering and that failed native-service removal triggers rollback of the newly-registered scheduler task.Testing
bun test tests/service.test.ts --test-name-pattern 'fresh Windows scheduler install gets|fresh scheduler install rolls back'and they passed.bun run typecheckand it passed.bun run test, but the environment could not complete the GUI build due to external registry downloads returning HTTP 403, so the full-suite run was environment-blocked (not a behavioral regression in these changes).Codex Task