[WRONG BRANCH] fix(lab): persist cursor-protobuf conformance evidence - #272
[WRONG BRANCH] fix(lab): persist cursor-protobuf conformance evidence#272luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6eb3e1b278
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case "cursor-protobuf": | ||
| return "cursor-protobuf"; |
There was a problem hiding this comment.
Map the Cursor wire protocol to the Cursor adapter
When any mcp-core conformance result is persisted, this records both subject.effectiveAdapter and the fingerprint's wire.adapter as cursor-protobuf, but that is the wire protocol rather than a registered adapter: the runtime's canonical adapter identifier is cursor (src/server/adapter-resolve.ts:76). Consequently, the ledger attributes MCP evidence to a nonexistent adapter and produces incompatible subject/fingerprint metadata for actual Cursor routes. Return cursor here while retaining cursor-protobuf in upstreamProtocol, and update the new test accordingly.
Useful? React with 👍 / 👎.
Motivation
cursor-protobufas their upstream protocol to throw during evidence persistence, preventing protocol conformance observations from being produced.Description
cursor-protobufto theupstreamAdapter()mapping socursor-protobufexecution contexts map to a valid effective adapter. (change insrc/lab/observe/from-conformance.ts).mcp-core.protocol.namespace-mappingscenario and asserts the produced observation subject haseffectiveAdapterandupstreamProtocolset tocursor-protobuf. (change intests/lab-evidence-ledger.test.ts).Testing
./node_modules/.bin/bun test tests/lab-evidence-ledger.test.ts, and the modified/related tests passed.bun run typecheck, which completed successfully../node_modules/.bin/bun run test; unrelated retained-root serialization races and management-editor timeouts were observed in the broader suite and are not caused by this small mapping change, so the focused affected suite was used as the verification signal.Codex Task