[WRONG BRANCH] fix(antigravity): preserve migrated default reasoning tier - #283
[WRONG BRANCH] fix(antigravity): preserve migrated default reasoning tier#283luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe migration adds conditional preservation for tier-specific legacy defaults. Antigravity Flash tier mappings retain their saved defaults while updating model lists and metadata. Tests verify deduplication and resolution to the new wire model with the historical thinking level. ChangesModel default preservation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized migration fix preserves tier-specific saved defaults while continuing to rename the underlying model, and no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a4d2612e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dropReasoningEffortMap: true, | ||
| // Tier-specific retired ids remain valid routing aliases. Replacing one when it is | ||
| // the saved default would discard its encoded tier and make 3.7 default to medium. | ||
| preserveDefaultModel: from !== "gemini-3.6-flash", |
There was a problem hiding this comment.
Preserve the tier through OAuth reconciliation
For the normal google-antigravity configuration with authMode: "oauth", this flag is undone during the same startup: startServer runs the rename migration and then reconcileOAuthProviders (src/server/index.ts:494-505), whose stale-default check replaces any default absent from the refreshed preset model list with gemini-3.7-flash (src/oauth/index.ts:935-942). Since the tier-bearing alias is deliberately removed from models, a saved gemini-3.6-flash-high therefore still becomes the medium default before requests are served. Preserve recognized compatibility aliases during OAuth reconciliation (or persist the tier separately), and cover the actual migration-plus-reconciliation sequence rather than testing the projection alone.
AGENTS.md reference: src/AGENTS.md:L24-L26
Useful? React with 👍 / 👎.
Motivation
gemini-3.6-flash-high) to the baregemini-3.7-flash, which dropped the tier encoded by the saveddefaultModeland caused routed calls to fall back to the 3.7 defaultthinkingLevel.Description
preserveDefaultModelflag toModelRenameto allow leaving a saveddefaultModeluntouched when the legacy id encodes request semantics the replacement cannot represent.preserveDefaultModelfor tier-specific retired Antigravity Flash ids (but not the baregemini-3.6-flash) so list/catalog fields are renamed while a tier-bearing saved default is retained.projectModelRenamesto skip rewritingprov.defaultModelwhenrename.preserveDefaultModelis true.tests/gemini-37-flash-migration.test.tsto assert that a migratedgemini-3.6-flash-highremains the saved default and still resolves togemini-3.7-flashwith `thinkingLevel:Codex Task
Summary by CodeRabbit