fix: align GA kits with directory major 23 (+ per-kit Kotlin 2.2.20)#731
Conversation
….x metadata The ga-23 and ga4-23 directories encode wrapped firebase-analytics major 23, but both pinned firebase-analytics:[22.1.0,23.0.0) (major 22). Bumped the firebase-analytics and lockstep play-services-measurement-api ranges to [23.0.0,24.0.0). firebase-analytics 23.x ships Kotlin 2.1/2.2 metadata (23.0.0 -> 2.1.0, 23.2.0 -> 2.2.0), which the kits' Kotlin 2.0.20 compiler cannot read, so the range bump alone fails compileReleaseKotlin. Bumped these two kits' ext.kotlin_version to 2.2.20, matching the existing per-kit override pattern already used by urbanairship-20 (2.2.20) and rokt (2.1.20). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR SummaryMedium Risk Overview Because those kits can’t share the multi-kit Reviewed by Cursor Bugbot for commit 9f6a8bf. Bugbot is set up for automated code reviews on this repo. Configure here. |
firebase-analytics 23.x ships Kotlin 2.1/2.2 metadata that the repo's root Kotlin Gradle plugin (2.0.20) cannot read, so the GA kits cannot compile in the aggregate settings-kits.gradle build. Per-kit ext.kotlin_version has no effect there because the aggregate compiler is fixed by the root buildscript. Follow the established urbanairship-20 isolated-kit pattern so the GA kits are built standalone with their own Kotlin 2.2.20: - Remove ga-23/ga4-23 from kits/matrix.json (no aggregate build-kits jobs). - Comment them out of settings-kits.gradle and remove their example modules from settings-kit-examples.gradle. - Add isolated compatibility (pull-request.yml) and lint/ktlint/test (daily.yml) steps that run `-p kits/ga/ga-23` / `-p kits/ga4/ga4-23`. - Document both kits under "Currently isolated" in ONBOARDING.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…otlin-workstation-6 Signed-off-by: Nickolas Dimitrakas <nickolas.dimitrakas@rokt.com>
|
3 participants
Summary
Split out from #730. The
ga-23andga4-23directories encode wrapped firebase-analytics major 23, but both kits pinnedfirebase-analytics:[22.1.0,23.0.0)(major 22).ga/ga-23firebase-analytics:[22.1.0,23.0.0)+play-services-measurement-api:[22.1.0,23.0.0)[23.0.0,24.0.0)ga4/ga4-23[23.0.0,24.0.0)play-services-measurement-api(test dep) is released in lockstep withfirebase-analytics, so it moves to 23 too.Why the Kotlin bump
firebase-analytics 23.x ships Kotlin 2.1/2.2 metadata (
23.0.0→ 2.1.0,23.2.0→ 2.2.0), which the kits' current Kotlin 2.0.20 compiler cannot read — the range bump alone failscompileReleaseKotlinwith:So this PR also bumps only these two kits'
ext.kotlin_versionto2.2.20. This follows the established per-kit Kotlin override pattern already in the repo —urbanairship-20uses2.2.20androktuses2.1.20, both building alongside the 2.0.20 kits in the same aggregate CI. No repo-wide toolchain change is needed.Verification
firebase-analytics/play-services-measurement-api23.2.0are published, so ranges resolve.23.0.0→2.1.0,23.2.0→2.2.0) against the repo's 2.0.20 compiler.Build ga-23,Build ga4-23,Kit Compatibility Test, andLint Checksgo green.The pre-existing
cross-platform-testsfailure (:android:buildSrc:compileKotlin+ emulator infra, unrelated) is not addressed here.🤖 Generated with Claude Code