dr_wav: Fix signed integer overflow in MSADPCM decoder - #335
Open
timblechmann wants to merge 1 commit into
Open
Conversation
nibble * delta in drwav_read_pcm_frames_s16__msadpcm can overflow drwav_int32 (nibble ±8, delta up to 0x7FFFFFFF), as can the sum with the coefficient prediction. Found by UBSan/ClusterFuzz. Add drwav__msadpcm_calc_sample() that computes the full sample in int64 and clamps the final result to [-32768, 32767].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nibble * delta in drwav_read_pcm_frames_s16__msadpcm can overflow drwav_int32 (nibble ±8, delta up to 0x7FFFFFFF), as can the sum with the coefficient prediction. Found by UBSan/ClusterFuzz.
Add drwav__msadpcm_calc_sample() that computes the full sample in int64 and clamps the final result to [-32768, 32767].
minimized reproducer: clusterfuzz-testcase-minimized-dr_wav_fuzzer-4682179674963968.tar.gz