Skip to content

Fix contributor attribution for GSA checks#2003

Merged
merill merged 1 commit into
mainfrom
codex/fix-contributor-attribution
Jul 26, 2026
Merged

Fix contributor attribution for GSA checks#2003
merill merged 1 commit into
mainfrom
codex/fix-contributor-attribution

Conversation

@merill

@merill merill commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Root cause

The contributor feature (#1999) and its fallback snapshot merged before #1992. PR #1992 then squash-merged as commit 28cd9bfe, correctly authored by Christopher Brumm <30894952+crmhh@users.noreply.github.com>. The identity resolver handles that noreply address directly, but the committed snapshot still ended at MT.1186. Shallow-clone website deployments therefore used the old snapshot and omitted Christopher even though full-history generation produced the right attribution.

Validation

  • node scripts/generate-test-docs.mjs --check under Node 24
  • full npm run build Docusaurus production build
  • assertions that crmhh owns MT.1187–MT.1195 in contributors.json
  • built contributor and MT.1187 pages contain Christopher Brumm
  • git diff --check

No blog migration files are changed.

Summary by CodeRabbit

  • New Features

    • Added documentation for nine new Maester tests covering Entra-related security checks.
    • Expanded test overviews, tags, metadata, remediation guidance, and source references.
    • Added links from test metadata to related command documentation.
  • Documentation

    • Standardized test pages with consistent overview, remediation, related links, metadata, and source sections.
    • Updated test counts and contributor attribution information.
  • Tests

    • Website builds now validate generated test documentation and contributor attribution automatically.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1e3a635f-1926-4906-aa66-50834a1aeae5

📥 Commits

Reviewing files that changed from the base of the PR and between 50595be and 8512ac0.

📒 Files selected for processing (15)
  • .github/workflows/build-website.yaml
  • website/docs/tests/maester/MT.1186.md
  • website/docs/tests/maester/MT.1187.md
  • website/docs/tests/maester/MT.1188.md
  • website/docs/tests/maester/MT.1189.md
  • website/docs/tests/maester/MT.1190.md
  • website/docs/tests/maester/MT.1191.md
  • website/docs/tests/maester/MT.1192.md
  • website/docs/tests/maester/MT.1193.md
  • website/docs/tests/maester/MT.1194.md
  • website/docs/tests/maester/MT.1195.md
  • website/docs/tests/maester/readme.md
  • website/docs/tests/readme.md
  • website/docs/tests/tags/readme.md
  • website/src/data/contributors.json

📝 Walkthrough

Walkthrough

Regenerates Maester documentation for MT.1187–MT.1195, updates test and contributor indexes, links MT.1186 metadata to command documentation, and runs generated-doc validation in the website build workflow.

Changes

Maester documentation regeneration

Layer / File(s) Summary
Generated test page layout
website/docs/tests/maester/MT.1186.md, website/docs/tests/maester/MT.1187.mdMT.1195.md
Standardized generated frontmatter, content sections, test metadata, source references, and the MT.1186 PowerShell test link.
Test and tag catalog updates
website/docs/tests/maester/readme.md, website/docs/tests/readme.md, website/docs/tests/tags/readme.md
Added MT.1187–MT.1195 to test listings and tag indexes, and updated suite and tag counts.
Contributor and attribution data
website/src/data/contributors.json
Added contributor, authored-test, attribution, and test definitions for MT.1187–MT.1195 and adjusted existing commit counts.
Generated documentation CI check
.github/workflows/build-website.yaml
Runs npm run check-test-docs with GH_TOKEN before the website build.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • maester365/maester#1992: Adds the Global Secure Access checks corresponding to the regenerated MT.1187–MT.1195 documentation.

Suggested labels: documentation, github_actions, automation

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-contributor-attribution

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying maester with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8512ac0
Status: ✅  Deploy successful!
Preview URL: https://8e23b2a9.maester.pages.dev
Branch Preview URL: https://codex-fix-contributor-attrib.maester.pages.dev

View logs

@merill
merill marked this pull request as ready for review July 26, 2026 00:50
@merill
merill requested review from a team as code owners July 26, 2026 00:50
@merill
merill merged commit ec4a65b into main Jul 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant