Repository navigation
fix(msrc): an entry is found by the products it affects, not only by its title - #56
Merged
Merged
Conversation
…its title `patchradar scan "windows 11"` found nothing in MSRC. MSRC titles an entry by component and names the operating system only in the document's ProductTree, which each entry points into through its ProductStatuses, and the keyword was matched against the title and the notes alone. On the October 2026 document, which lists 1,057 entries affecting a Windows 11 product, `windows 11` and `windows 10` found 0 and `windows server` 4. An entry is now also kept when the keyword names, by the same whole-word rule as titles, one of the products it lists as Known Affected (Type 3). Run on the whole October document, served locally: 1,057, 980 and 1,099, in the same ~195 ms; curl and excel unchanged. Tests read a recorded excerpt of that document: three entries verbatim (a Windows Kernel CVE affecting Windows 11 26H2, a Windows Server-only one, an Excel one) and the product names they point to. The two product tests failed first; the word rule and the Type 3 rule, written after, each fail when the rule is removed. The status test uses a derived entry, declared as such: the document holds only Type 3. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merging this PR will not alter performance
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
codecov/patch on #56: the `continue` past a product that is not an object had no test. A derived excerpt, the recorded one with a string at the head of FullProductName, still finds the kernel entry for "windows 11" — the robustness the collector already keeps per vulnerability entry, now held per product too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The defect (audit finding PR-02)
patchradar scan "windows 11"found nothing in MSRC. The October 2026 document lists 1,057 entries affecting a Windows 11 product, and KB5127648, October's Windows 11 cumulative update, was installed on the machine that ran the scan.MSRC titles an entry by component ("Windows Kernel Information Disclosure Vulnerability"). The operating system is named only in the document's
ProductTree, which each entry points into throughProductStatuses. The keyword was matched against title and notes only. The September fixture had noProductTree, so no test could notice.Fix
An entry is also kept when the keyword names one of the products the entry lists as Known Affected (
ProductStatusesType 3). The match uses the same whole-word rule as titles (keyword_pattern). The matching product IDs are computed once per monthly document.Measured on the whole real October 2026 document, served locally
windows 11windows 10windows serverwindowscurl/excel1,057 is exactly the number of entries the audit counted with a Windows 11 product in
ProductStatuses.Tests
tests/fixtures/msrc_2026_oct_excerpt_recorded.json, from the real document downloaded on 2026-10-17. It keeps three entries verbatim and theFullProductNames they point to (62 KB):windows 11finds the kernel entry, andwindows serverfinds the cluster entry and not Excel. Both failed first.winfinds none);Not in this PR: reporting the KB of the remediation for the matched product, and comparing it with installed updates. That is a follow-up.
🤖 Generated with Claude Code