Repository navigation
feat(import): --accept writes the products a person confirmed - #63
Closed
maksimtech wants to merge 1 commit into
Closed
maksimtech wants to merge 1 commit into
maksimtech wants to merge 1 commit into
Conversation
`import` proposes and a person confirms, and what gets remembered is the confirmation (inventory.py). Until the watchlist had the columns the confirmation had nowhere to go and the command wrote nothing. - `--accept "<name>"`, once per product, any of its registry entries: a product the survey identified completely (Chrome, Edge) is watched with the registry's version and its vendor source in vendor and product_id (set_source). - A source without its product, a component, a program nothing answers for: refused with the survey's own reason, exit 1; what was confirmed beside it is still written. - Without --accept nothing is written, and the closing line says how to accept instead of naming columns this release no longer lacks. - README, the NIS2 document and DESIGN 5.6 say what import writes. Tests first, seen failing; the mutants for each refusal, the version, the exit code and the lookup by any registry entry are killed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Owner
Author
|
Folded into #64, which now targets main with every commit of the stack: one review, one merge, no conflicts from squash merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Audit finding PR-01, step 01c-1 (docs/DESIGN.md §5.6). Stacked on #62; the order is #59 → #60 → #61 → #62 → this one.
What was wrong
importproposes and a person confirms, and what gets remembered is the confirmation (inventory.py). Until the watchlist had the columns, the confirmation had nowhere to go: the command wrote nothing and ended by saying "a confirmed mapping needs the watchlist columns … which this release does not have".What changes
patchradar import <file> --accept "<name>", repeatable, once per product. The name can be that of any registry entry in the product's family.vendor/product_id(set_source, from fix(watchlist): vendor and product_id are the vendor source's, as inventory.py meant #62).--acceptnothing is written, and the closing line says how to accept.channelstays empty: the two certain sources today are matched without it (DESIGN §5.6 says so).docs/nis2-compliance.md(import writes to the local watchlist only on--accept) and DESIGN §5.6 updated.Tests (strict TDD)
tests/test_import_accept.py, 11 tests in the style oftest_cli_import.py, with snapshots built in the collector's shape:--accept;🤖 Generated with Claude Code