[Feature] 프론트 요구사항에 맞춰, api 응답 Long id를 스트링으로 변경 및 신고 요청 dto 구분 - #81
Open
Sehi55 wants to merge 6 commits into
Open
[Feature] 프론트 요구사항에 맞춰, api 응답 Long id를 스트링으로 변경 및 신고 요청 dto 구분#81Sehi55 wants to merge 6 commits into
Sehi55 wants to merge 6 commits into
Conversation
|
Warning Review limit reached
Next review available in: 43 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Walkthrough신고 생성 API를 채팅 신고와 프로필 신고로 분리했습니다. 요청 검증과 신고 ID 응답을 추가했습니다. 활성 신고 재사용, 신고자 잠금 조회, 프로필 식별자 전달, Changes신고 생성 기능
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant ReportController
participant ReportService
participant UserRepository
participant ReportRepository
ReportController->>ReportService: 채팅 또는 프로필 신고 생성 요청
ReportService->>UserRepository: 신고자 잠금 조회
ReportService->>ReportRepository: 활성 신고 조회
ReportService->>ReportRepository: 기존 신고 ID 반환 또는 신규 신고 저장
ReportService-->>ReportController: reportId 응답
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@manabom/src/main/java/mannabom_server/manabom/application/report/dto/request/CreateChatReportRequest.java`:
- Around line 17-21: Add `@Positive` validation with appropriate messages to
contextId and targetId in CreateChatReportRequest.java and to profileId in
CreateProfileReportRequest.java, while retaining their existing `@NotNull` checks
so all report IDs must be greater than zero and non-null.
In
`@manabom/src/test/java/mannabom_server/manabom/infrastructure/config/JacksonConfigTest.java`:
- Around line 30-32: Update JacksonConfigTest at
manabom/src/test/java/mannabom_server/manabom/infrastructure/config/JacksonConfigTest.java
lines 30-32 to assert isTextual() for userId, recipientUserIds[0], and
data.roomId before checking their text values; apply the same JSON string-type
assertions to userId and profileId at lines 49-50.
In
`@manabom/src/test/java/mannabom_server/manabom/presentation/report/controller/ReportControllerTest.java`:
- Around line 21-24: Update the CreateProfileReportRequest setup in
ReportControllerTest to include a valid ReportReason value alongside profileId.
Keep the existing service stubbing and success-response assertions unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 46c59132-87b6-4923-8042-6727fbe95d2b
📒 Files selected for processing (15)
manabom/src/main/java/mannabom_server/manabom/application/meeting/dto/response/MatchedChatRoomInfo.javamanabom/src/main/java/mannabom_server/manabom/application/report/dto/request/CreateChatReportRequest.javamanabom/src/main/java/mannabom_server/manabom/application/report/dto/request/CreateProfileReportRequest.javamanabom/src/main/java/mannabom_server/manabom/application/report/dto/request/CreateReportRequest.javamanabom/src/main/java/mannabom_server/manabom/application/report/dto/response/CreateReportResponse.javamanabom/src/main/java/mannabom_server/manabom/application/report/service/ReportService.javamanabom/src/main/java/mannabom_server/manabom/domain/chat/repository/ChatMemberQueryRepository.javamanabom/src/main/java/mannabom_server/manabom/domain/report/repository/ReportRepository.javamanabom/src/main/java/mannabom_server/manabom/domain/user/repository/UserRepository.javamanabom/src/main/java/mannabom_server/manabom/infrastructure/config/JacksonConfig.javamanabom/src/main/java/mannabom_server/manabom/presentation/report/controller/ReportController.javamanabom/src/test/java/mannabom_server/manabom/application/report/dto/request/ReportRequestValidationTest.javamanabom/src/test/java/mannabom_server/manabom/application/report/service/ReportServiceTest.javamanabom/src/test/java/mannabom_server/manabom/infrastructure/config/JacksonConfigTest.javamanabom/src/test/java/mannabom_server/manabom/presentation/report/controller/ReportControllerTest.java
💤 Files with no reviewable changes (1)
- manabom/src/main/java/mannabom_server/manabom/application/report/dto/request/CreateReportRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
Summary by CodeRabbit
새 기능
버그 수정