fix: use OpenAPI 'minimum' for timestamp DateTime formats - #1067
Open
Sanjays2402 wants to merge 1 commit into
Open
fix: use OpenAPI 'minimum' for timestamp DateTime formats#1067Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
DateTime fields with format="timestamp" or "timestamp_ms" were converted
to a schema containing "min": "0". "min" is not an OpenAPI Schema Object
keyword, so the generated spec failed validation with
openapi-spec-validator ("Property 'min' is not allowed").
Emit the standard "minimum" keyword with a numeric 0 instead.
lafrech
requested changes
Aug 18, 2026
| "format": "float", | ||
| "example": "1676451245.596", | ||
| "min": "0", | ||
| "minimum": 0, |
There was a problem hiding this comment.
In this case, the value "0" is invalid and causes the validator to fail, as I already mentioned in the opened Issue.
See example https://spec.openapis.org/oas/v3.0.2#simple-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1064
DateTime(format="timestamp")/format="timestamp_ms"produced"min": "0", which is not an OpenAPI Schema Object keyword, so the generated spec failedopenapi-spec-validatorwithProperty 'min' is not allowed. Emits the standard numericminimum: 0instead; the two existing timestamp tests are updated to match.This change was prepared with AI assistance; the regression test was run locally and fails without the fix.