Matrix inputs: expose delimiter shapes to assistive technology - #1851
Merged
sangwinc merged 2 commits intoAug 26, 2026
Merged
Conversation
Render localized left and right delimiter elements with the ARIA math role around fixed and variable-size matrix inputs. Cover square brackets, parentheses, curly brackets and vertical bars while omitting accessibility elements for the no-brackets setting. Keep visual rendering unchanged, centralize the shared markup in the input base class, and update documentation and focused renderer tests.
The API controller test expected the matrix table to directly follow the bracket wrapper. Account for the left accessibility span added by this pull request before the table.
Member
|
Thanks @adamant-pwn that's very helpful and much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the accessibility discussion in #1849, this exposes the visual delimiters around fixed and variable-size matrix inputs to assistive technology.
Each visible left and right delimiter has a corresponding empty
spanwithrole="math"and a localizedaria-label. This covers square brackets, parentheses, curly brackets and vertical bars. The no-brackets setting emits no accessibility elements.The existing visual CSS and input API metadata are unchanged.
Verification
matrixparensvalues for both matrix input types.iss1848branch produced no conflicts, and PHP syntax checks pass for all modified PHP files.