Repository navigation
Bump to 1.38.1 - #118
Merged
Merged
Bump to 1.38.1#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A model whose workspace part is cut inside a complex variable opens:
MatParser.parseMatrixleft the value null for acomplex numeric variable cut before its real part, and
MatlabVariableNode._createFromMatNumeric's complex arm thenread
.reand refused the whole model; such a variable is now built by the real arms, as a real variable cut at thesame point already is, with no warning (cut every byte over the 22 repo fixtures with a workspace part: 124 of 86,102
cuts refused at 1.38.0, 0 now, 85,978 unchanged, 0 regressed). And the empty-zip check of #114 accepts
PK\x05\x06only as a real empty archive, at least 22 bytes with both entry counts 0, so other bytes that merely begin with it are
refused as
Not a Simulink modelagain, as before 1.38.0 (#116). Both were the "still open" items of 1.38.0 (#117).Left out, as #116 reports: a workspace variable whose flags word is overwritten (class 255) is damage, not a cut, and
still refuses the model.
Gate:
npm run verifypassed (rc 0). Test files: 238 passed, 1 skipped (239). Tests: 7922 passed, 26 skipped (7948).The other stages were also green: typecheck, build, smoke, check:pack, check:leak and check:browser (156 modules, no
node:builtins);dist/rebuilt from scratch is unchanged.