Repository navigation
Bump to 1.39.0 - #120
Merged
Merged
Bump to 1.39.0#120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The barrel exports the pieces that carry a FunctionElement rename into the System Composer interface dictionary's
catalog, for a host that renames in the catalog itself rather than through the session's save:
scFunctionRenameEdits(the edits for each renamed function's
p_Nameandp_FunctionPrototype, the privatefunctionRenameEditsrenamed),scanScJsonFunctionsandscanScXmlFunctions(the catalog's functions in a textual dictionary's JSON and a binaryone's catalog member), and the types
ScFunctionandCatalogFunctionRenames; no behaviour changes, both save writerscall the same code, and the exported API and the session's save write byte-equal catalogs in 33 checks across both
formats (#119). The vscode editors use it to carry a function rename into the catalog, the half of the maintainer's A5
ruling that #109 could not reach. A minor version, since it adds public API.
Gate:
npm run verifypassed (rc 0). Test files: 238 passed, 1 skipped (239). Tests: 7929 passed, 26 skipped (7955).The other stages were also green: typecheck, build, smoke, check:pack, check:leak and check:browser (156 modules, no
node:builtins);dist/rebuilt from scratch is unchanged.