Update expected UI screenshots for the restyled selects and drag handle, PG-942 - #274
Draft
snake14 wants to merge 11 commits into
Draft
Update expected UI screenshots for the restyled selects and drag handle, PG-942#274snake14 wants to merge 11 commits into
snake14 wants to merge 11 commits into
Conversation
Bump plugin version to 6.0.0 and require Matomo >=6.0.0-b1,<7.0.0-b1.
…violations (#266) * Adapt Vue sources to the Vite build and rebuild dist for Matomo 6 Replaces a value re-export/import of a type-only entity so the esbuild-based Vite build can bundle it, and rebuilds the Vue dist files with the new toolchain. * Rebuild Vue dist files for Vue 3.5 * Fix CustomAlerts Vue declaration type errors Export the Alert interface and type the alerts list, replace duplicate v-model model-value bindings with update handlers, drop a stray updateAlert arg, and coerce optional alert fields.
* Run plugin tests against MySQL 8.0 and MariaDB 10.6 The workflow inherited the shared action's MySQL 5.7 default, which is below Matomo's new minimum. Pin the database-backed jobs to the supported floor: PluginTests now runs a MySQL 8.0 + MariaDB 10.6 matrix, and the UI/JS jobs run on MySQL 8.0. * Only upload plugin test artifacts for the MySQL matrix leg PluginTests runs a MySQL + MariaDB matrix; the upload-artifacts condition matched both legs and uploaded twice. Restrict the upload to the MySQL leg.
… Puppeteer 24) (#269) * Update expected UI screenshots for the new headless Chrome (Node 24 / Puppeteer 24) * Move mouse off the alert-condition dropdown before capturing The reloaded-alert-condition tests open and expand the condition dropdown via jQuery (page.evaluate), so the real mouse cursor is left resting over the dropdown from an earlier click. Under Chrome 149 that gives whichever option is under the cursor a stray :hover highlight in the screenshot. Move the mouse to a neutral position before capturing so no option is highlighted. * Sync corrected alert-condition screenshots (no stray dropdown hover) * Run the plugin UI tests on Node 24 Match the Node 24 / Puppeteer 24 screenshot-testing stack; the UI job was still pinned to Node 16.
Teal brand screenshots on 6.x-dev plugin base; synced from matomo-org/matomo run 30405694397.
Teal brand screenshots on 6.x-dev plugin base; synced from matomo-org/matomo run 30405694397.
Matomo's Vue build no longer emits <Plugin>.umd.js. Only the minified CustomAlerts.umd.min.js is ever served: PluginUmdAssetFetcher looks exclusively for .umd.min.js, and development mode uses the .development.umd.js produced by vue:build --watch. The unminified bundle was a leftover from Vue CLI, whose lib build emitted it alongside the minified one for free. See matomo-org/matomo#25027.
…d drag handle Generated against the commit matomo core's 6.x-dev currently pins, by matomo-org/matomo#25033's CI run.
…able-list-handle # Conflicts: # tests/UI/expected-ui-screenshots/CustomAlerts_alert_condition_reloaded_site1.png # tests/UI/expected-ui-screenshots/CustomAlerts_alert_condition_reloaded_site2.png # tests/UI/expected-ui-screenshots/CustomAlerts_edit.png # tests/UI/expected-ui-screenshots/CustomAlerts_report_mediums.png
…r the viewport edge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to matomo-org/matomo#25033 (restyled expandable selects and the standard drag handle): updates this plugin's 4 expected UI screenshots to the new component rendering. The screenshots were generated by that PR's CI and synced from its artifacts, then reviewed individually — the diffs are the restyled components only.
This branch is cut from the commit matomo core's
6.x-devcurrently pins for this plugin (one commit ahead of theprepare6xmerge-base), because that pin is what core CI renders; the core PR advances its gitlink to this branch. Targeted atprepare6xas the 6.x line; the small base divergence is pre-existing pin drift.Merge-order dependency: this PR's own UI check tests against plain
6.x-devand fails on exactly the synced screenshots until matomo-org/matomo#25033 merges — the new expectations render only with that PR's restyle. Merge matomo#25033 first, then this.Issue No
Related to matomo-org/matomo#25033 (PG-942)
Steps to Replicate the Issue
Checklist