Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The required coverage merge job failed before coverage processing because the public pull-request
.diffendpoint returned HTTP 503 through its retry window. A rerun of the same MatrixOne head succeeded, but the workflow had no fallback. Related: matrixorigin/matrixone#29223.Change
For public repositories, try the public
.diffendpoint first, then fall back to the authenticated GitHub Pull Requests API diff endpoint. Both requests have bounded retries and timeouts. The helper verifies the expected PR head and diff statistics before and after download. It accepts an empty diff only when GitHub reports zero changed files; nonempty responses must parse as Git patches whose file, added-line, and deleted-line counts match PR metadata. It publishes from a temporary file only after validation. The private-repository path is unchanged.Validation
bash -n scripts/fetch_public_pr_diff.sh; Ruby Psych parsed the changed workflow;git diff --checkpassed.00b4a36, including all 13 tests inscripts/test_fetch_public_pr_diff.py. They cover HTTP 503 fallback, empty and malformed bodies, incomplete file and hunk lists, metadata drift, and cleanup after failure.00b4a36also returned a Git-parseable 17,800-byte diff matching the four changed files and metadata line counts.A full MatrixOne Coverage workflow run after merge will verify the reusable-workflow integration.