Conversation
XuPeng-SH
marked this pull request as draft
September 24, 2026 19:06
XuPeng-SH
force-pushed
the
codex/coverage-cluster-timeout-20260925
branch
from
September 24, 2026 19:29
36f3fb6 to
9aedafb
Compare
XuPeng-SH
force-pushed
the
codex/coverage-cluster-timeout-20260925
branch
from
September 24, 2026 19:44
0e4853d to
9aedafb
Compare
XuPeng-SH
marked this pull request as ready for review
September 24, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
Coverage uses the full
-coverpkgscope for each of 486 Go test packages. Three successful MatrixOne runs each wrote about 16.2 GB of mostly duplicate profile records. After tests passed, the current AWK compaction took about 274 seconds on the observed runner, reducing the profile to about 30.7 MB. This serial tail consumes CPU and memory and extends the total Coverage job.The earlier
pkg/tests/issues/isolatedtimeout was caused by package runtime that included embedded-cluster admission waits; #459 already raised the package deadline to 20 minutes. This PR reduces total Coverage work without changing that deadline or the test schedule.Change
Replace the post-test AWK pass with a standard-library Go compactor. It reads the raw file incrementally, retains one exact source-block/statement-count key with OR-ed hit state, applies the same exclusions, and sorts the resulting records. Memory scales with distinct blocks instead of duplicate rows. It writes beside the raw file and replaces it only after a complete, validated write; failures leave the raw input intact and fail the existing publication gate.
The single
go testinvocation,-p 8, full-coverpkg, 20-minute package deadline, 60-minute suite watchdog and process-group cleanup are unchanged. Compaction starts only after tests pass, so it cannot compete with or backpressure the test processes.Related: matrixorigin/matrixone#29368.
Validation
go runcommand took 56.5 s including build on that input.go test,go vet,actionlint, workflow shell syntax andgit diff --checkpass. GPT-6 medium design and overall review found no material implementation blocker.go testandgo vetwith pinned Go 1.26.4. A deliberately failing test returned a nonzero status in the local gate probe. The new-head ARM64 check passed, including the Go test and vet step.Compaction on the actual production profile, complete Coverage job duration and downstream merge still require validation after merge. The test execution phase is unchanged, so this PR claims a shorter total CI path, not a faster
go testphase or a statistical guarantee about flakiness.