Spec consistency follow-ups: discovery set, read routing, temp scale#8
Merged
Conversation
Follow-up review pass closing the remaining cross-references that still disagreed after the contradiction batch: - Module discovery: renamed to the "SDK discovery set" and stated it is not "all active modules" — it legacy-probes the deprecated iBeacon (0x07) and Humidity (0x16) opcodes while omitting NeoPixel/ANCS/GSR/ Color/Proximity; added a matching note under the discovery-order list. - Board-init step now distinguishes present (full info) from absent (bare [opcode, 0x80]) responses, consistent with the discovery rule. - Data-processor src_reg: "(not OR'd with 0x80)" was wrong for read-based sources; now spells out streaming = plain register, read-based = loud-read form (0x81/0x86/0x87). - Bit-6 packet note: silent reads feed LOGGER TRIGGERS only; data processors are fed by loud reads (was "loggers and data processors"). - Temperature: removed the unjustified "data format may be backend-driver specific" hedge — all channels use channel + int16/8 (0.125 C); corrected the introductory table's "2 byte Address" to one byte. - Macro ADD_PARTIAL/ADD_COMMAND split: clarified the ambiguous cmd_byte2..cmd_byteN-2 notation to "all remaining bytes." mkdocs build --strict passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up review pass closing the remaining cross-references that still disagreed after the contradiction batch (PR #7):
0x07) and Humidity (0x16) while omitting NeoPixel/ANCS/GSR/Color/Proximity. Matching note added under the discovery-order list.[opcode, 0x80]) responses.src_reg: "(not OR'd with 0x80)" was wrong for read-based sources → streaming = plain register, read-based = loud-read form (0x81/0x86/0x87).cmd_byte2..cmd_byteN-2notation clarified to "all remaining bytes."mkdocs build --strictpasses.🤖 Generated with Claude Code