Repository navigation
📝 Fix docs pages that are empty or don't match the package - #220
Merged
Merged
Conversation
- The Signal page persisted signals with `persistSignals` and `localStorageAdapter`, which aren't exported. It now uses `usePersistSignals` with `createLocalStorageAdapter`. - `isServer` is a boolean, not a function. - `isPromiseLike`'s signature is a type guard. - `useMount` pointed to a `useLifecycles` hook that doesn't exist. Claude-Session: https://claude.ai/code/session_01BvSDyJABLGit75HAjpnsqm
…ntents `arrayEqual`, `isDefined`, `isShallowEqual`, `useConstant`, `useLiveRef` and `retryBackoff` are exported, and their pages said only "todo". The table of contents drops the pages the previous commit removed: `isPlainObject`, `difference`, `filterObjectByKey`, `trackSubscriptions` and `emitToSubject`. None is exported, so their examples failed on import. It also lists `shallowEqual` under its exported name, `isShallowEqual`. Claude-Session: https://claude.ai/code/session_01BvSDyJABLGit75HAjpnsqm
mbret
marked this pull request as ready for review
November 3, 2026 12:38
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71069078d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
`every` skips the holes of a sparse array, so `arrayEqual(new Array(1), [1])` returned true while the reversed call returned false. A loop compares every index. Claude-Session: https://claude.ai/code/session_01BvSDyJABLGit75HAjpnsqm
It compares `constructor` and `Object.keys`, so the page no longer promises the same prototype or every own key. Claude-Session: https://claude.ai/code/session_01BvSDyJABLGit75HAjpnsqm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Code copied from the docs fails on import. The Utils section documents five functions the package doesn't export, and the Signal page persists signals with two names that don't exist.
Six exported utils have a page that says only "todo".
What's new
isPlainObject,difference,filterObjectByKey,trackSubscriptions,emitToSubjectarrayEqual,isDefined,isShallowEqual,useConstant,useLiveRef,retryBackoffusePersistSignalsandcreateLocalStorageAdapterOther changes
arrayEqualcompares every index, so a hole in a sparse array no longer counts as equalisServershown as a boolean andisPromiseLikeas a type guarduseMountpage no longer points to auseLifecycleshookDetails
arrayEqualusedevery, which skips holes:arrayEqual(new Array(1), [1])wastrueand the reversed callfalse. Itsfixcommit releases a patch version on merge.shallowEqualpage moves toisshallowequal.md, under its exported name. Old links to it and to the five removed pages now 404.filterObjectByKeystays insrc/: auseObserveselector test uses it.🔍 Self-reviewed with selfcorrect-review
🤖 Made within harness coverage
🤖 Generated with Claude Code
https://claude.ai/code/session_01BvSDyJABLGit75HAjpnsqm