[Symphony]: Hide long-term alerts in departures pages - #3428
Merged
Conversation
joshlarson
reviewed
Aug 18, 2026
joshlarson
left a comment
joshlarson
left a comment
Contributor
There was a problem hiding this comment.
The feature looks good (I think), but I think it would be worth it to add a few tests to the alerts section of the schedule finder live tests validating that this behaves the way we want.
…re no longer relevant. New tests will be written once the new logic is in place. The structure of the main fix should still be fne.
joshlarson
requested changes
Aug 24, 2026
joshlarson
left a comment
joshlarson
left a comment
Contributor
There was a problem hiding this comment.
I know I'm a broken record about this kind of thing, but I do think we should have a test that validates that the stale alert doesn't show up typically (and a test that validates that it does show up on the Symphony page, and that other station closures do show up, etc).
…ide_stale_alerts_on_departures # Conflicts: # lib/dotcom_web/live/schedule_finder_live.ex
joshlarson
requested changes
Aug 25, 2026
thecristen
reviewed
Aug 25, 2026
joshlarson
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🐬 Hide long-term alerts in departures pages
Implementation
Added function to filter out stale alerts that don't target this stop specifically
Screenshots
Dev at Hynes
Local at Hynes
Local at Symphony
How to test
http://localhost:4001/departures?route_id=Green&direction_id=1&stop_id=place-hymnl - Confirm that the Symphony closure alert is gone for other stops on the route
http://localhost:4001/departures?route_id=Green&direction_id=1&stop_id=place-symcl - Confirm that for Symphony itself the alert still shows up