feat: New bespoke Harbor Loop Ferry timetable layout - #3432
Open
joshlarson wants to merge 11 commits into
Open
Conversation
smartling-github-connector
Bot
added
the
Not Ready for Translation
joshlarson
removed
the
Not Ready for Translation
…-loop-ferry-layout (#3452) * Translations delivered for PR#3432 on es-LA locale * Translations delivered for PR#3432 on ht-HT locale * Translations delivered for PR#3432 on zh-TW locale * Translations delivered for PR#3432 on pt-BR locale * Translations delivered for PR#3432 on fr-FR locale * Translations delivered for PR#3432 on vi-VN locale * Translations delivered for PR#3432 on zh-CN locale --------- Co-authored-by: smartling-github-connector[bot] <165276057+smartling-github-connector[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: ⛴️ Render F10 schedule using the new bespoke F10 layout
Important
This feature is not behind a feature flag, so if this PR is merged, then on the next deploy, this will go live to riders. I think that's okay, but since most of the other timetable work I've done has been behind the
new_timetables?feature flag, I wanted to make sure that this PR's non-flagged nature was clear.Implementation
Note
I used 🤖 Copilot to generate the first commit of this PR. I've inspected the code and tests, and my tweaks and changes are the remaining commits.
NewTimetable.timetable/1component rather thanTimetable.timetable/1because the buttons onTimetable.timetable/1can only work if there's a single timetable on the page (this is the entire reason thatNewTimetableexists).Screenshots
How to test
Visit the Harbor Loop Ferry timetable page.
Try it out for different dates and browser widths.
A thing that I tried, just to validate a corner case that I admit would surprise me, was to change
evening_schedulesormorning_schedulesto[]in theBoat-F10assign_trip_schedules/1clause. This is the result (Copilot's initial implementation was much less nice):(I did this before the refactor in this commit, which removes the explicit
morning/evening_schedulesvariables.)Try out whatever else you think of!