feat(ScheduleFinderLive): show in-seat transfers - #3451
Draft
thecristen wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Just testing out this idea...
Implementation
Yesterday I wrote a library to pull in and update GTFS data.
Then here I wrote a helper function to access the relevant rows from
transfers.txt.Then I updated the departures page, to be able to show you the extra stops you can reach if you stay aboard.
Some choices made:
Bonus: I am trying out
position: stickyto keep the route+headsign in view when you scroll down the list of schedules:Screenshots
57.mov
How to test
In transfers.txt we can see the trips which come into play, so we can look up those trips and find departures pages to test. I've been enjoying these:
(for the 37/57 and maybe others, you'll have to select the weekday service that's not yet active -- because the trips of concern happen when school is in session).
TODO: I need to add tests here.