QF | BadMapError: expected a map, got: nil - #3453
Open
lvachon1 wants to merge 1 commit into
Open
Conversation
…xpectedly nil. The particular code in question was updating route to be route.id but route was nil. I figured that means the id is nil too. This will likely have downstream effects, so I'll look for those next. Added a unit test for this edge case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: QF | BadMapError: expected a map, got:
Implementation
The schedule controller was encountering data where the route was unexpectedly nil. The particular code in question was updating
route = route.idbutroutewasnil. I figured that means the id is nil too. Added a unit test for this edge case.Turns out this function is there to reformat data before it is returned via the API as JSON. One one hand, this PR solves this particular error, this request should not crash when encountering this type of data. On the other hand, if the consumer of this API data isn't expecting route to be
nil/nullthen this just kicks the can down the road.I'll try to find a consumer for this call and see what's what.
Update: From what I can tell this API call is only used by the stop page.
Screenshots
N/A
How to test
Unit test