feat: declare the vendored modules in a manifest - #53
Merged
Conversation
mcanouil
added
the
Type: Refactor 🔥
mcanouil
marked this pull request as ready for review
September 6, 2026 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five Lua modules the extension takes from
quarto-lua-moduleswere plain copies under_extensions/code-window/_modules/, with nothing recording where they came from.They now move to
_extensions/code-window/_vendor/quarto-lua-modules/and are listed in_extensions/code-window/_dependencies.yml, which names the source repository, the release, the licence, and a SHA-256 for each file.The vendoring script can then refetch them and check a copy against the release it claims to be.
html.lua,logging.lua,metadata.luaandpandoc-helpers.luawere the 1.0.0 files and are declared and refreshed at 2.0.0.string.luacarried a version no release published, so it is adopted and brought to 2.0.0 as well.cell-output.lua,language.luaand_modules/hotfix/are first party and stay under_modules/.code-window.luaandmain.luaload the moved modules from their new path.The documentation sync script also loses the scaffolder placeholders in its header, which never got a licence and an author name.