feat(pr-review): add non-blocking pre-mortem review track#79
Open
Troublor wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an independent, non-blocking pre-mortem track to the shared
claude-pr-reviewaction, following the "Pre-mortem based Agent PR Review" methodology (minimal-integration variant):premorteminput (defaulton): after the standard review converges, the lead agent spawns a fresh sub-agent with no shared context that assumes the PR already shipped and caused a production incident, and reconstructs the most credible failure paths (≤8 candidates, top 5 selected).confirmed/plausible_unverified/rejected/stale/out_of_scope).(pre-mortem, confirmed));plausible_unverifieditems (≤3) appear only in the review body as verification requests; the rest are suppressed.COMMENT, neverREQUEST_CHANGES. We collect developer accept/reject feedback in production before considering any gating.premortem: off).Changes
.github/actions/claude-pr-review/premortem.md(new): role prompts for the Pre-mortem Reviewer, Evidence Verifier, and the lead's Judge/merge rules, staged into.claude-review/likerubric-detail.md..github/actions/claude-pr-review/action.yml: newpremorteminput;Tasktool enabled when the track is on; pre-mortem orchestration block injected into the prompt; security-boundary paragraph; Phase 5 comment cap..github/workflows/claude.yml:timeout-minutes25 → 35 for the pr-review job (the track adds two rounds of sub-agent work)..github/actions/README.md: document the new input and the 35-minute timeout recommendation.Verified locally: both YAML files parse; the compose script passes
bash -nand was executed in a simulated CI environment for bothpremortem=on(orchestration block emitted,Taskallowed,premortem.mdstaged) andpremortem=off(block empty, noTask, nothing staged).Note: since this PR touches
claude.yml, the automated pr-review job skips itself on this PR (existing self-modification guard) — first real-world run will be on the next PR after merge.