Skip to content

fix(review): skip the cost hold when the owner already recorded the cost decision #9403

Closed

Description

@kyle-sexton

Refs: #9276, #9224

Problem

The code-review lane's cost hold (#9342, ci-workflows v0.64.1 apply-review-hold) runs again on every new head. It adds needs-human even when the owner has already recorded the cost decision for that PR, as a **Decision recorded.** Cost: comment on the closing issue, which is the #9224 rule.

Seen on #9332:

Every later base merge repeats this, so the owner is pulled back into a loop he has already closed.

Done when

  • A review lane does not apply a cost hold when the PR's closing or linked issue carries an owner-authored **Decision recorded.** Cost: comment newer than the PR's createdAt. The babysit merge gate already reads this, in babysit_risk.py's cost rule.
  • The owner check uses the same author rule as the babysit cost gate: the owner's account, unedited, not an agent login.
  • A test covers it: a cost-class change with a recorded decision gets no hold; without one, it is held.
  • Holds for the trust-gate and critical-security classes are unchanged.

Where

The /review:code-review skill's hold criteria (plugins/review, #9342) and/or the hold step's deterministic inputs. Pick the place that can read the issue comment reliably. A skill instruction alone is model judgment; prefer a deterministic check in the hold step or the ci-status gate.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 23, 2026
  2. github-actions commented on Oct 23, 2026

    @github-actions
    Contributor

    Proposed work class: none

    Thanks for the report. Automated triage handed this issue to a maintainer.

    Unconfirmed model suggestion: work-class: structural
    Basis: automated intake triage; a maintainer confirms or changes it.

    Automated triage. A maintainer reviews it.

  3. added
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.status: needs-decisionAwaiting a human or maintainer judgment call.

    Type

    Fields

    No fields configured for Bug.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions