You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(pr-pipeline): decide code-owner review on .github/** and verify the ci-status lanes hold step's runner tools #9422
ci-status's step Fail a lanes App pull request its body or a member holds (pr-require-checks.yml) is what stops an already-armed lanes App pull request when a hold appears. On pull_request and merge_group it runs from the pull request's own workflow file, so a push that edits that step could remove the check. The current mitigation: the melodic-automation-lanes App installation has no workflows permission (only contents: write), so it cannot push changes under .github/workflows. Also, apply-patch refuses .github/workflows paths as protected-path. Two gaps remain:
Owner's call: require code-owner or ruleset review on .github/**, so the guard does not rest on the App's permission set alone. Options: a CODEOWNERS entry with a ruleset requiring code-owner review; a ruleset path restriction on .github/** for the lanes App; or keep the permission-based mitigation.
Unverified: the ci-status job has no setup-node. The step uses the runner image's node, which needs path.matchesGlob (Node 20.17+/22.5+), and yq. If either is missing, the step fails closed on every lanes App pull request. It does not fail open. Check the first lanes App pull request's ci-status log after feat(pr-pipeline): arm native auto-merge for lane pull requests #9399 merges, or pin the tools in the job.
Acceptance
The owner decides on item 1 and records the decision.
A lanes App pull request's ci-status log shows the hold step reaching its verdict line, or the job pins node and yq.
Activity
github-actions commentedon Oct 23, 2026
Proposed work class: none
Thanks for the report. Automated triage handed this issue to a maintainer.
Automated triage. A maintainer reviews it.