Repository navigation
ci: run comment-hygiene locally in check-affected so a comment violation fails before push #9648
Description
Problem
The comment-hygiene check is CI-only (scripts/check-affected-gates.txt:32, "comment-hygiene ci-only ci-workflows composite"). Neither the pre-push hook nor check-affected.sh runs it, so a PR that adds an issue number, run id or date to a code comment finds out only after a full CI round. The lint-repo annotation then says only "Hygiene check comment-hygiene finished with outcome: failure", because the composite action's output is not captured, so finding the line takes another step.
On 2026-10-24 this happened three times:
- fix(pr-merge): recompute an unverified-stale post-merge answer in lane_room and annotate room holds #9602 (lint-repo job 120802693376, four
issue #9577comments): red about 1 h. - fix(pr-merge): bind a cost decision to the pull request it names #9569 (run 40076212602): red about 4.5 h.
- fix(pr-pipeline): derive a lane PR's link line from the remaining work it names #9630 (run 40076369625): red about 4.5 h.
Fix
Run the same patterns locally in check-affected.sh, against the changed files' comment lines. Read them from the pinned ci-workflows check-comment-markers/comment-hygiene-patterns.sh, not from a copy, so the local and CI checks cannot drift. Optionally, have the composite action print the offending file:line to the job log, so the CI annotation points at it.
Who uses it: every builder that pushes, before CI spends a run on it.
Activity
github-actions commentedon Oct 24, 2026
Proposed work class: work-class: scoped
Basis: automated intake triage; the lanes App applied this class.
Size: Small
Complexity: Medium
Uncertainty: Known
Flags: none
Understood: the comment-hygiene check runs only in CI, so comment violations (issue numbers, run ids, dates) are found after a full CI round. You propose running the same patterns locally in
check-affected.sh. The patterns would be read from the pinned ci-workflowscomment-hygiene-patterns.sh, so local and CI can't drift. Optionally the composite action would print the offendingfile:lineto the job log.Nothing essential is missing. One point for the implementer to confirm: the pinned ci-workflows file must be reachable locally without a network fetch. I found no likely duplicates among the open issues.
Automated triage, applied by the lanes App.
melodic-automation-lanes commentedon Oct 24, 2026
Not admitted to the issue lane: no trusted-human acceptance criteria: a listed human must put the confirmed
- [ ]criteria in the body or post them as their own comment (owner Q9, #8999). A recorded decision does not change these rules (.github/actions/resolve-config/admission-rules.json); a person who wants it worked addsagent-ready.