Skip to content

ci(intake): repin intake-triage to ci-workflows v0.65.10 and skip apply-verdict on a deferred triage #10036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Oct 25, 2026
Merged

ci(intake): repin intake-triage to ci-workflows v0.65.10 and skip apply-verdict on a deferred triage #10036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/actions/resolve-config/callers.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,16 @@ test("intake-triage.yml: apply-verdict writes as the lanes App only after a tria
assert.deepEqual(workflow("intake-triage.yml").permissions, {}, "no workflow-level grant");
assert.equal(job.concurrency["cancel-in-progress"], false);
assert.notEqual(job.concurrency.group, jobs["intake-triage"].concurrency.group, "its own concurrency group");
const runs = (result, failed) => evaluate(job.if, { "needs.intake-triage.result": result, "needs.intake-triage.outputs.triage-failed": failed });
const runs = (result, failed, deferred = "") =>
evaluate(job.if, {
"needs.intake-triage.result": result,
"needs.intake-triage.outputs.triage-failed": failed,
"needs.intake-triage.outputs.triage-deferred": deferred,
});
assert.equal(runs("success", "false"), true);
assert.equal(runs("success", ""), true);
assert.equal(runs("success", "true"), false, "a triage that did not run writes nothing");
assert.equal(runs("success", "", "true"), false, "a deferred triage wrote no lane comment");
assert.equal(runs("failure", "false"), false, "a failed apply writes nothing");
assert.equal(runs("skipped", ""), false);

Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/intake-triage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ jobs:
concurrency:
group: intake-triage-${{ github.event.issue.number || inputs.issue-number || github.run_id }}
cancel-in-progress: false
uses: melodic-software/ci-workflows/.github/workflows/intake-triage.yml@b0ecc273abe492d12f2efa98ee4741a84c219ed2 # b0ecc27 2026-10-23 v0.65.0 plus a docs-only commit
uses: melodic-software/ci-workflows/.github/workflows/intake-triage.yml@215cec5c362f953f8b6196effb04451696c3f970 # 215cec5 2026-10-25 v0.65.10
with:
runner: ubuntu-24.04
role: intake
Expand Down Expand Up @@ -341,13 +341,15 @@ jobs:
# against closed enums; on `status: ready`, admit.mjs adds agent-ready (or
# admission-deferred over a cap) when the admission rules hold. It runs only
# after a triage that ran and applied, and reads only a lane comment written
# since this run started.
# since this run started. A deferred triage wrote no lane comment, so
# apply-verdict skips it.
apply-verdict:
needs: [born-triaged, intake-triage]
if: >-
${{ !cancelled()
&& needs.intake-triage.result == 'success'
&& needs.intake-triage.outputs.triage-failed != 'true' }}
&& needs.intake-triage.outputs.triage-failed != 'true'
&& needs.intake-triage.outputs.triage-deferred != 'true' }}
runs-on: ubuntu-24.04
timeout-minutes: 10
concurrency:
Expand Down
Loading