Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/actions/resolve-config/callers.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -1310,7 +1310,7 @@ test("the trigger-gate check names an ungated job and accepts only the lanes' ga
const admit = (step = { id: "gate", uses: TRUSTED_TRIGGER }) => ({ outputs: { proceed: "${{ steps.gate.outputs.proceed }}" }, steps: [step] });
const gates = (on, jobs) => Object.fromEntries(gatedTriggerJobs(["f.yml"], () => ({ on, jobs })));
const intake = (uses, ids) => ({ uses, with: { "allowed-author-ids": ids }, secrets: { CLAUDE_CODE_OAUTH_TOKEN: "${{ secrets.AUTOMATIONS_CLAUDE_CODE_OAUTH_TOKEN }}" } });
const PINNED = "melodic-software/ci-workflows/.github/workflows/intake-triage.yml@2fe38c031867900824c164e33a140a335ed9ecf0";
const PINNED = "melodic-software/ci-workflows/.github/workflows/intake-triage.yml@d02b8697e092705153f0996549b05f95a446bb52";
const cases = {
"ungated issues job": [{ issues: { types: ["labeled"] } }, { run: { steps: [launcher] } }, { "f.yml run": [] }],
"ungated issue_comment job": [{ issue_comment: { types: ["created"] } }, { run: { steps: [launcher] } }, { "f.yml run": [] }],
Expand Down Expand Up @@ -1367,7 +1367,7 @@ test("pr-run-activity-read.yml: the run job can only read, and each launcher ste
const { jobs } = workflow("pr-run-activity-read.yml");
assert.deepEqual(jobs.run.permissions, { contents: "read", "pull-requests": "read" }, "read-only, no id-token");
const step = (id) => jobs.run.steps.find((s) => s.id === id);
const launcher = "melodic-software/ci-workflows/.github/actions/run-claude-cli@164c2809f6150429b6f24d4a2777bb377af953d9";
const launcher = "melodic-software/ci-workflows/.github/actions/run-claude-cli@d02b8697e092705153f0996549b05f95a446bb52";
for (const [id, input, secret] of [
["act-key", "api-key", "claude-api-key"],
["act-token", "subscription-token", "claude-code-oauth-token"],
Expand Down Expand Up @@ -1424,9 +1424,13 @@ test("no run-claude-cli plugin-dirs or add-dirs value names runner.temp, RUNNER_
// Launcher SHAs checked to pass `--permission-prompts none` unconditionally,
// under which the default mode denies every call no rule allows, as dontAsk
// does; check-permission-mode.sh accepts default for dontAsk on that basis.
// 7b362428: lane.cjs:311-312; 164c2809: lane.cjs:355-358; in cliArgs. A pin bump fails here until its
// lane.cjs is read and its SHA added.
const PERMISSION_PROMPTS_NONE_LAUNCHERS = new Set(["7b362428c76085a160e28656cd2c75c3147a69ff", "164c2809f6150429b6f24d4a2777bb377af953d9"]);
// 7b362428: lane.cjs:311-312; 164c2809: lane.cjs:355-358; d02b8697: lane.cjs:357-358; in cliArgs. A pin
// bump fails here until its lane.cjs is read and its SHA added.
const PERMISSION_PROMPTS_NONE_LAUNCHERS = new Set([
"7b362428c76085a160e28656cd2c75c3147a69ff",
"164c2809f6150429b6f24d4a2777bb377af953d9",
"d02b8697e092705153f0996549b05f95a446bb52",
]);

test("pr-run-activity-read.yml: every run-claude-cli pin is a launcher checked to pass --permission-prompts none", () => {
const pins = [];
Expand Down Expand Up @@ -3229,7 +3233,7 @@ test("scan job: every gate, skip and launcher class value the runner sets passes
const schema = JSON.parse(read("../../../docs/conventions/pr-pipeline/pr-pipeline.schema.json"));
const gateReasons = Object.keys(JSON.parse(read("../report-check-run/gate-skip-reasons.json")));
// run-claude-cli's failure classes, the keys of SUMMARY_NOTES in lane.cjs at
// the pinned 164c2809. cant-fail-ok: an external contract's value list.
// the pinned d02b8697. cant-fail-ok: an external contract's value list.
const laneClasses = ["credit-stop", "rate-limit", "auth", "overloaded", "max-turns", "timeout", "other"];
const cases = [
...schema.$defs["skip-reason"].enum.map((value) => ["skip-reason", value]),
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/pr-verify/probe/replay.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const REPOSITORY = "melodic-software/claude-code-plugins";
// apply-claude-managed-settings to. cliArgs, LEG_ENV, CLI_VERSION and
// MANAGED_SETTINGS were read from that SHA; the parity test fails when the
// pin moves, so they are read again.
export const RUN_CLAUDE_CLI_PIN = "164c2809f6150429b6f24d4a2777bb377af953d9";
export const RUN_CLAUDE_CLI_PIN = "d02b8697e092705153f0996549b05f95a446bb52";
export const CLI_VERSION = "latest";
export const MANAGED_SETTINGS = Object.freeze({
apiKeyHelper: "",
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/intake-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ jobs:
concurrency:
group: intake-triage-${{ github.event.issue.number || inputs.issue-number || github.run_id }}
cancel-in-progress: false
uses: melodic-software/ci-workflows/.github/workflows/intake-triage.yml@2fe38c031867900824c164e33a140a335ed9ecf0 # v0.62.0
uses: melodic-software/ci-workflows/.github/workflows/intake-triage.yml@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
with:
runner: ubuntu-24.04
role: automations
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-review-hosted.yml
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ jobs:
contents: read
pull-requests: write # the review, its inline comments and the lane's
# reviewed-head marker comment
uses: melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@6d6cb798e7cb7560a0f9327d8a22398961c23b31 # v0.64.2
uses: melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
with:
lane: code
publish: comments
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-review-security-hosted.yml
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ jobs:
contents: read
pull-requests: write # the review, its inline comments and the lane's
# reviewed-head marker comment
uses: melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@6d6cb798e7cb7560a0f9327d8a22398961c23b31 # v0.64.2
uses: melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
with:
lane: security
publish: comments
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/pr-run-activity-read.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@ jobs:
# need sudo, so they are written before the runner is isolated.
- name: Apply the Claude managed settings
if: steps.launch.outcome == 'success' && steps.go.outputs.run == 'true'
uses: melodic-software/ci-workflows/.github/actions/apply-claude-managed-settings@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/apply-claude-managed-settings@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0

# Nothing after this step needs sudo or docker.
- name: Isolate the runner
Expand Down Expand Up @@ -1299,7 +1299,7 @@ jobs:
if: steps.key-present.outputs.present == 'true'
continue-on-error: true
timeout-minutes: 50
uses: melodic-software/ci-workflows/.github/actions/run-claude-cli@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/run-claude-cli@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
env:
# No work may outlive the result message the launcher reads.
CLAUDE_CODE_DISABLE_BACKGROUND_TASKS: "1"
Expand Down Expand Up @@ -1351,7 +1351,7 @@ jobs:
if: steps.token-present.outputs.present == 'true'
continue-on-error: true
timeout-minutes: 50
uses: melodic-software/ci-workflows/.github/actions/run-claude-cli@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/run-claude-cli@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
env:
CLAUDE_CODE_DISABLE_BACKGROUND_TASKS: "1"
LD_LIBRARY_PATH: ""
Expand Down Expand Up @@ -1697,7 +1697,7 @@ jobs:
if: >-
always() && inputs.issue-number != ''
&& (steps.act-skill.outcome == 'success' || steps.act-skill.outcome == 'failure')
uses: melodic-software/ci-workflows/.github/actions/report-lane-outcome@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/report-lane-outcome@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
with:
outcome: ${{ steps.act-result.outputs.outcome || steps.act-skill.outcome }}
execution-file: >-
Expand All @@ -1716,7 +1716,7 @@ jobs:
always() && steps.key-present.outputs.present != 'false' && steps.act-key.outputs.lane-class != 'credit-stop'
&& (steps.act-key.outcome == 'success' || steps.act-key.outcome == 'failure'
|| steps.act-token.outcome == 'success' || steps.act-token.outcome == 'failure')
uses: melodic-software/ci-workflows/.github/actions/report-lane-outcome@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/report-lane-outcome@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
with:
outcome: ${{ steps.act-key.outcome != 'skipped' && steps.act-key.outcome || steps.act-token.outcome }}
execution-file: ${{ steps.act-key.outputs.execution-file || steps.act-token.outputs.execution-file }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-run-activity-write.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1610,7 +1610,7 @@ jobs:
- name: Record the lane outcome
id: lane-record
if: always() && (steps.act-skill.outcome == 'success' || steps.act-skill.outcome == 'failure')
uses: melodic-software/ci-workflows/.github/actions/report-lane-outcome@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/report-lane-outcome@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
with:
outcome: ${{ steps.act-result.outputs.outcome || steps.act-skill.outcome }}
execution-file: >-
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/pr-verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ jobs:
# need sudo, so they are written before the runner is isolated.
- name: Apply the Claude managed settings
if: steps.agree.outcome == 'success'
uses: melodic-software/ci-workflows/.github/actions/apply-claude-managed-settings@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/apply-claude-managed-settings@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0

- name: Isolate the runner
if: steps.agree.outcome == 'success'
Expand Down Expand Up @@ -259,7 +259,7 @@ jobs:
if: steps.credential.outputs.present == 'true'
continue-on-error: true
timeout-minutes: 22
uses: melodic-software/ci-workflows/.github/actions/run-claude-cli@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/run-claude-cli@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
env:
# No work may outlive the result message the launcher reads.
CLAUDE_CODE_DISABLE_BACKGROUND_TASKS: "1"
Expand Down Expand Up @@ -318,7 +318,7 @@ jobs:
# it, and auth as auth.
- name: Report the judgment's outcome
if: (steps.judge.outcome == 'success' || steps.judge.outcome == 'failure') && (steps.judge.outputs.handoff != 'true' || steps.key-leg.outcome == 'failure')
uses: melodic-software/ci-workflows/.github/actions/report-lane-outcome@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/report-lane-outcome@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
with:
outcome: ${{ steps.judge.outcome }}
execution-file: ${{ steps.judge.outputs.execution-file }}
Expand Down Expand Up @@ -533,7 +533,7 @@ jobs:
# need sudo, so they are written before the runner is isolated.
- name: Apply the Claude managed settings
if: steps.agree.outcome == 'success'
uses: melodic-software/ci-workflows/.github/actions/apply-claude-managed-settings@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/apply-claude-managed-settings@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0

- name: Isolate the runner
if: steps.agree.outcome == 'success'
Expand Down Expand Up @@ -581,7 +581,7 @@ jobs:
if: steps.credential.outputs.present == 'true'
continue-on-error: true
timeout-minutes: 22
uses: melodic-software/ci-workflows/.github/actions/run-claude-cli@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/run-claude-cli@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
env:
# No work may outlive the result message the launcher reads.
CLAUDE_CODE_DISABLE_BACKGROUND_TASKS: "1"
Expand Down Expand Up @@ -616,7 +616,7 @@ jobs:

- name: Report the judgment's outcome
if: steps.judge.outcome == 'success' || steps.judge.outcome == 'failure'
uses: melodic-software/ci-workflows/.github/actions/report-lane-outcome@164c2809f6150429b6f24d4a2777bb377af953d9 # v0.61.0
uses: melodic-software/ci-workflows/.github/actions/report-lane-outcome@d02b8697e092705153f0996549b05f95a446bb52 # v0.65.0
with:
outcome: ${{ steps.judge.outcome }}
execution-file: ${{ steps.judge.outputs.execution-file }}
Expand Down
6 changes: 3 additions & 3 deletions scripts/ci-review-lanes.test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ for pair in 'pr-review-hosted.yml pr-review:' 'pr-review-security-hosted.yml pr-
caller="$ROOT/.github/workflows/$file"
if grep -qxF " $job" "$caller" && grep -qxF ' publish: comments' "$caller" &&
grep -qxF ' hold-label: needs-human' "$caller" &&
grep -qE '^ uses: melodic-software/ci-workflows/\.github/workflows/pr-review-cli\.yml@6d6cb798e7cb7560a0f9327d8a22398961c23b31 # v0\.64\.2$' "$caller"; then
ok "$file calls pr-review-cli v0.64.2 as job ${job%:} with publish: comments and hold-label: needs-human"
grep -qE '^ uses: melodic-software/ci-workflows/\.github/workflows/pr-review-cli\.yml@d02b8697e092705153f0996549b05f95a446bb52 # v0\.65\.0$' "$caller"; then
ok "$file calls pr-review-cli v0.65.0 as job ${job%:} with publish: comments and hold-label: needs-human"
else
fail "$file lost its job id, publish: comments, hold-label or v0.64.2 pin"
fail "$file lost its job id, publish: comments, hold-label or v0.65.0 pin"
fi
paths="$(awk '/^ hold-paths: \|$/ { on = 1; next } on && /^ / { sub(/^ +/, ""); print; next } on { exit }' "$caller")"
if [[ "$paths" == $'.github/standards/trusted-actors/**\n.github/actions/check-trusted-trigger/**\n**/CODEOWNERS\n**/.gitmodules' ]]; then
Expand Down
Loading