Skip to content

chore(ci): re-pin the review callers to ci-workflows v0.65.1 - #9556

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/repin-review-callers-v0.65.1
Oct 24, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
chore/repin-review-callers-v0.65.1

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: the review lanes on #9545 (runs 40054659344 and 40054659337) finished the model leg, but the runner dropped the review output ("Skip output 'review' since it may contain secret"), and the status job reported incomplete.

Summary

Re-pins both review callers to ci-workflows v0.65.1 (b49ac366). That release passes the review between pr-review-cli.yml's jobs as an artifact checked by sha256, so a review that quotes a registered secret's value still publishes (ci-workflows#874).

Fix

  • .github/workflows/pr-review-hosted.yml and .github/workflows/pr-review-security-hosted.yml: only the uses: pin line changes, d02b8697 (v0.65.0) to b49ac366 (v0.65.1).
  • scripts/ci-review-lanes.test.sh: the pin it asserts.
  • Runner policy: .github/standards/runner-policy/policy.json already registers the new SHA, from standards#864, synced here in #9555. Inputs and secrets are unchanged.

Verification

  • bash scripts/ci-review-lanes.test.sh: PASS=55 FAIL=0.
  • node --test .github/actions/resolve-config/callers.test.mjs: 161 pass, 0 fail. It names no pr-review-cli SHA.
  • actionlint on both callers: clean. zizmor --offline: no findings.
  • GITHUB_TOKEN REST requests per review run are unchanged (pinned in ci-workflows' pr-review-cli-api-calls.test.cjs). The artifact upload and download use the Actions runtime token.

Related

🤖 Generated with Claude Code

v0.65.1 passes the review between pr-review-cli's jobs as an artifact,
so a review that quotes a registered secret's value no longer reaches
the status job empty (ci-workflows#874).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T03:27:30.862113Z 2729bc5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kyle-sexton
kyle-sexton enabled auto-merge October 24, 2026 03:26
@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 2729bc56562c130f82e4e86e725901df32eed700: 0 finding(s), 0 as inline comments.

No findings. I read the diff and the PR context and ran one grep for the old and new SHAs.

The PR changes the uses: pin for pr-review-cli.yml from v0.65.0 (d02b8697) to v0.65.1 (b49ac366) in pr-review-hosted.yml and pr-review-security-hosted.yml. It updates the pin that scripts/ci-review-lanes.test.sh asserts to match.

Checked with the grep:

  • Both callers and the test assertion use the same SHA and the # v0.65.1 comment.
  • .github/standards/runner-policy/policy.json:930 registers pr-review-cli.yml@b49ac366…, so the runner policy accepts the new pin.
  • The remaining d02b8697 references are other ci-workflows actions and workflows (pr-verify.yml, intake-triage.yml, pr-run-activity-*.yml) plus related test constants. The PR scopes itself to the review callers, so I did not flag them. Whether those should move too is a decision for the author.

Not run: I did not run the test suites, actionlint or zizmor. The PASS=55 and 161-pass figures in the description are the author's claims and I have not confirmed them.

Hold: none. The change adds no model call, no new trigger and no new runner. It touches no trusted-actors, check-trusted-trigger, CODEOWNERS or .gitmodules file. It has no closing issue and no plugin manifest changes.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 2729bc56562c130f82e4e86e725901df32eed700: 0 finding(s), 0 as inline comments.

No security issues found in this pull request.

The diff re-pins the two review caller workflows (pr-review-hosted.yml, pr-review-security-hosted.yml) from ci-workflows v0.65.0 to v0.65.1. It also updates the pin asserted in scripts/ci-review-lanes.test.sh.

  • Pin form: the new pin is a full 40-character commit SHA in the same organization's reusable workflow, so the pin is no looser than before.
  • Runner policy: .github/standards/runner-policy/policy.json:930 already registers this exact SHA.
  • Unchanged: the diff changes no with: inputs, secrets, permissions: or triggers, so the callers keep the same grants. The hold-label and hold-paths settings are untouched, and the test script still asserts them.
  • Not checked: I could not read the v0.65.1 release content (no network access). The claim that the review now passes between jobs as a sha256-checked artifact is unverified. Supply-chain pin changes are zizmor's lane, and the PR reports it clean.
  • PR context: it holds no embedded instructions aimed at the review lane.
  • Instruction surfaces: none are touched.
  • Manifests: no plugin manifests are touched.
  • Trust-gate paths: no trusted-actors, check-trusted-trigger, CODEOWNERS or .gitmodules paths are touched.

critical-findings: 0

@kyle-sexton
kyle-sexton added this pull request to the merge queue Oct 24, 2026
Merged via the queue into main with commit 91b0d4d Oct 24, 2026
36 checks passed
@kyle-sexton
kyle-sexton deleted the chore/repin-review-callers-v0.65.1 branch October 24, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant