Repository navigation
chore(ci): re-pin the review callers to ci-workflows v0.65.5 - #9589
Conversation
v0.65.2 makes each review job report the job token's api budget and stops the hold step re-adding a cost hold the owner already decided. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review needs no new review of Security review (incremental since 5d32b27)No security findings. critical-findings: 0 What changed since the last review: the incremental diff has three files.
Checked:
Note: the PR description says the |
|
claude-review needs no new review of Incremental review of 5d32b27..7e90de2. This push re-pins both review callers from ci-workflows v0.65.4 to v0.65.5 ( No findings.
|
…contract (#867) No related issue: follow-up to [ci-workflows#876](melodic-software/ci-workflows#876). claude-code-plugins' review callers pin to this release in [claude-code-plugins#9589](melodic-software/claude-code-plugins#9589). ## Summary Registers `pr-review-cli.yml@f133c6651f866845e18595d26cf59d4043b5b642`, which is ci-workflows [v0.65.3](https://github.com/melodic-software/ci-workflows/releases/tag/v0.65.3). ## Fix v0.65.3 changes only `apply-review-hold/hold.cjs` and its test. `git diff --stat e7f935fc f133c665` lists those two files and nothing else. `pr-review-cli.yml` is byte-identical to v0.65.2, so the contract copies the v0.65.2 entry from [#866](#866) forward verbatim. ## Verification - `node --test runner-policy.test.mjs` in `components/runner-policy`: 345 pass, 0 fail. This includes the new copy-forward test. ## Related - [#866](#866) (v0.65.2) and [#864](#864) (v0.65.1) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
v0.65.3 aligns the hold step's cost-decision matching with the merge-side readers (#9569). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A recorded cost decision now carries only while the pull request's net diff against its base is unchanged (ci-workflows#877). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…contract (#870) Refs: melodic-software/claude-code-plugins#9589 ## Summary Registers `pr-review-cli.yml@31b44f3ffc7f208fb281dd2b64decce67c53d316`, which is ci-workflows [v0.65.4](https://github.com/melodic-software/ci-workflows/releases/tag/v0.65.4). claude-code-plugins re-pins its review callers to it in [claude-code-plugins#9589](melodic-software/claude-code-plugins#9589). ## Fix v0.65.4 ([ci-workflows#877](melodic-software/ci-workflows#877)) carries a recorded cost decision only while the pull request's net diff against its base is unchanged. In `pr-review-cli.yml` the only non-comment change is `BASE_REF` added to the hold step's `env`. The `workflow_call` inputs differ only in one input description, secrets and permissions are untouched, and the runner is unchanged. The contract copies the v0.65.3 entry from [#867](#867) forward verbatim, with a copy-forward test. ## Verification - `node components/runner-policy/runner-policy.mjs --root .`: Runner policy passed. - `node --test components/runner-policy/runner-policy.test.mjs`: 346 pass, 0 fail, including the new copy-forward test. ## Related - [#867](#867) (v0.65.3) and [#866](#866) (v0.65.2) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…contract (#871) Refs: melodic-software/claude-code-plugins#9589 ## Summary Registers the `pr-review-cli.yml` reusable-workflow contract at ci-workflows v0.65.5 (`f1096608192c54cfb3dc252e36670e6f86700b9b`), so callers pinned to that release pass runner-policy. ## Fix Copies the v0.65.4 entry (`@31b44f3ffc7f208fb281dd2b64decce67c53d316`) forward in `components/runner-policy/policy.json` and adds the matching copy-forward test in `runner-policy.test.mjs`, as #870 did. `gh api compare v0.65.4...v0.65.5` on ci-workflows lists three changed files; the `pr-review-cli.yml` patch is comment-only (ci-workflows#878: a cost decision carries only from an unedited hold marker), so inputs, secrets and permissions are unchanged. ## Verification - `node components/runner-policy/runner-policy.mjs --root <worktree>`: Runner policy passed. - `node --test components/runner-policy/runner-policy.test.mjs`: 347 tests, 347 pass, 0 fail. ## Related - melodic-software/claude-code-plugins#9589 (re-pins the review callers to v0.65.5) - #870 (the v0.65.4 contract) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Refs: #9436
Summary
Re-pins both review callers to ci-workflows v0.65.5 (
f1096608). That release combines ci-workflows#875 (v0.65.2), ci-workflows#876 (v0.65.3), ci-workflows#877 (v0.65.4) and ci-workflows#878. It makes two changes:pr-review-cli.ymljob (review-key,review-subscription,status) now ends by writing theapi-budgetnotice (token=github-token ... cost=N) in the format of feat(ci): log GITHUB_TOKEN spend from each job's own responses #9432. The notice is built from thex-ratelimit-*headers of requests the job already makes, so it spends no request of its own.costhold again when the owner has recorded a cost decision for the pull request, and that decision carries only while the PR's net diff against its base is unchanged. This is the owner's Q18 (d), recorded on fix(pr-pipeline): carry an owner-lifted claude-review cost hold forward across base-only merges #9436. A decision on the linked issue must name#<number>.trust-gate,hold-pathsandcritical-securitystill hold.The decided head is the sha of the lane's newest cost hold marker posted before the decision. The decision covers the head when the head is that sha, or when
base...decidedandbase...headlist the same files with the same status, previous filename and patch text. A base-only merge or a rebase that leaves every patch alone carries; any edit of the PR's own diff, or a base change that shifts a patch's context, does not. A failed compare read, a file with no patch, or 300 or more files keeps the cost hold.v0.65.5 also carries a cost decision only from an unedited hold marker: a marker that was edited, or whose edit state cannot be read, carries nothing, and no older marker is used.
Fix
.github/workflows/pr-review-hosted.ymland.github/workflows/pr-review-security-hosted.yml: only theuses:pin line changes, fromb49ac366(v0.65.1) tof1096608(v0.65.5).scripts/ci-review-lanes.test.sh: the pin the test asserts, plus its ok and fail messages..github/standards/runner-policy/policy.jsondoes not yet register the new SHA. standards#871 adds it, with the same inputs and secrets as v0.65.4 (standards#870). Therunner-policycheck stays red here until that change syncs into this repository.Cost-decision lookup
The lookup fails closed. The cost hold stays when:
Refs:line that is not plain, twoRefs:issues, or aRefs:target that is a pull request);The
#<number>match and the Refs-number check are the same as #9569'snamesPulland Refs read.Three differences from the merge-side readers stay, and each fails closed at merge:
merge-holdsalso uses, rather than babysit's admin permission.Verification
bash scripts/ci-review-lanes.test.sh: PASS=55 FAIL=0.actionlinton both callers: clean.claude-review-keywrotetoken=github-token workflow=.github/workflows/pr-review-hosted.yml job=review-key run=40063803974 attempt=1 limit=5000 remaining=3742 used=1258 reset=1792818571 resource=core cost=5.pr-review-cli-api-calls.test.cjs. v0.65.4 and later add at most two compare reads, only when a cost decision exists and the head differs from the decided one.Related
🤖 Generated with Claude Code