Repository navigation
chore(ci): re-pin the review callers to ci-workflows v0.65.6 - #9660
Conversation
v0.65.6 carries a cost decision no further once a pull request comment was deleted since the decided-head hold marker (ci-workflows#879). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review needs no new review of No findings. I read the full diff and the PR context.
|
|
claude-security-review needs no new review of No security issues found in this pull request. The change moves the
manifest fields: none hit. |
Refs: #9436
Summary
Re-pins both review callers to ci-workflows v0.65.6 (
91426458), which adds one change over v0.65.5, ci-workflows#879: the hold step's cost-decision carry refuses to carry when any comment on the pull request was deleted at or after the decided-head hold marker was posted. A deleted newer marker would otherwise make an older one the decided head, so a decision could carry to a diff the owner never saw. The rule matchesdeletedSincein #9569'smerge-holds.mjs(owner decision Q18 d on #9436), and it fails closed when the timeline'sCOMMENT_DELETED_EVENTlist cannot be read, lists fewer events than itsfilteredCount, or holds a time that does not parse.Fix
.github/workflows/pr-review-hosted.ymland.github/workflows/pr-review-security-hosted.yml: only theuses:pin line changes, fromf1096608(v0.65.5) to91426458(v0.65.6).scripts/ci-review-lanes.test.sh: the pin the test asserts, plus its ok and fail messages.Verification
bash scripts/ci-review-lanes.test.sh: PASS=55 FAIL=0.actionlinton both callers: clean.gh api repos/melodic-software/ci-workflows/compare/v0.65.5...v0.65.6: three files (hold.cjs, its test, and a comment-onlypr-review-cli.ymlpatch), so the reusable workflow's inputs, secrets and permissions are unchanged.Remaining
#9436 is already closed; this PR is follow-up hardening of the review-lane reader it designed. Nothing else is left in this repository for the review lanes. The merge-side readers (
merge-holds.mjsbehindci-status, and babysit's merge policy) get the same deleted-comment rule in #9569, which is open and separate from this PR.Related
🤖 Generated with Claude Code