Repository navigation
feat(runner-policy): register the ci-workflows v0.63.0 pr-review-cli contract - #848
Conversation
…contract pr-review-cli is hosted-only: every job runs on ubuntu-24.04. The contract admits the reviews role's API key and its subscription token, so a caller can run the key leg first and the subscription leg after a handoff. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: no findingsI reviewed all 3 files in PR #848 (
|
|
claude-security-review reviewed Security review: PR 848 (head 2d477ce)No security findings. No inline comments posted. critical-findings: 0 Scope. The PR adds one hosted-only reusable-workflow contract for Checked (policy.json L756-L773):
Not verified. I could not read the pinned The instruction-exception register was not consulted, because the diff has no instruction-surface changes. |
…contract (#849) Refs: melodic-software/claude-code-plugins#9307 ## Summary Registers `pr-review-cli.yml@83b739f625b501ad40c65dee7168d836883195e1` (ci-workflows [v0.63.1](https://github.com/melodic-software/ci-workflows/releases/tag/v0.63.1)) so claude-code-plugins#9307 can re-pin its security lane to it. ## Fix v0.63.1 changes only the publish step ([ci-workflows#865](melodic-software/ci-workflows#865): titled completion notice, demoted CRITICAL findings counted). The contract copies the v0.63.0 entry forward verbatim: same routing, inputs and secrets. ## Verification - `node --test runner-policy.test.mjs` in `components/runner-policy`: 337 pass, including the new copy-forward test. ## Related - Same shape as #848 (v0.63.0). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Refs: melodic-software/claude-code-plugins#9276 ## Summary Registers `pr-review-cli.yml@4edeccd87cf60ef539ce5109b78454217d5f2049` (ci-workflows [v0.64.0](https://github.com/melodic-software/ci-workflows/releases/tag/v0.64.0)) so callers can pin it and pass its two new optional inputs, `hold-label` and `hold-paths`. ## Fix v0.64.0 adds an optional hold step to the status job ([ci-workflows#864](melodic-software/ci-workflows#864)). The new contract copies the v0.63.1 entry forward and appends `hold-label` and `hold-paths` to `allowedInputs`. Routing (`hosted-only`), `fixedRunsOn` (`ubuntu-24.04`) and the two reviews-role secrets are unchanged. No caller permission is added: the hold step writes through the status job's existing `pull-requests: write` grant. A diff of the workflow between v0.63.1 and v0.64.0 shows no other input, secret or `runs-on` change. ## Verification - `node --test runner-policy.test.mjs` in `components/runner-policy`: 338 pass, 0 fail, including the new test that the v0.64.0 entry equals v0.63.1 plus the two hold inputs. - `npm run lint:runner-policy`: passed. - `node --test components/claude-lanes/repin-policy-lockstep.test.mjs`: 23 pass. - Pre-commit (typos, editorconfig, markdownlint, gitleaks, biome): clean. ## Related - Same shape as #849 (v0.63.1) and #848 (v0.63.0). - After merge, the push-triggered `maintenance-sync-standards` run opens the sync PR into claude-code-plugins' `.github/standards/runner-policy/policy.json`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Refs: melodic-software/claude-code-account-rotation#259
Summary
Registers the runner-policy contract for ci-workflows v0.63.0
pr-review-cli.yml(8778094736e414233110f3e0d6d9948628ba77b5), so claude-code-plugins can move its live security review lane onto it.Fix
policy.json: a hosted-only contract,fixedRunsOn: ["ubuntu-24.04"], the inputslane,publish,role,model-args,allowed-bot-sender-ids,allowed-author-ids,docs-only-paths,incremental-reviewandcli-version, and both reviews-role secrets:CLAUDE_API_KEYfromREVIEWS_CLAUDE_API_KEY(tried first) andCLAUDE_CODE_OAUTH_TOKENfromREVIEWS_CLAUDE_CODE_OAUTH_TOKEN(after a key handoff).README.md: the v0.63.0 entry.runner-policy.test.mjs: pins the contract; the secret expressions are escaped template literals.Supersedes the key-only #847.
Verification
node --test components/runner-policy/runner-policy.test.mjs: 336 pass, 0 fail.node components/runner-policy/runner-policy.mjs --root .: passed.pr-review-cli.yml@8778094with both secrets: passed; the currently synced policy rejects the same caller withrunner-target-contract.Related
🤖 Generated with Claude Code