Fix/windows mpk xml#184
Closed
alihcsumer wants to merge 3 commits into
Closed
Conversation
weirdwater
requested changes
Jun 22, 2026
weirdwater
left a comment
weirdwater
left a comment
Collaborator
There was a problem hiding this comment.
Can you update the title to start with [WTF-2697]: to link the PR to the story?
| ); | ||
| if (missing.length) { | ||
| throw new Error(`Expected widget bundle files in mpk, but missing: ${missing.join(", ")}.`); | ||
| } |
Collaborator
There was a problem hiding this comment.
Since the function is only used in the testRelease method, we might as well just inline it there. Also, we might be able to combine these checks with the mpk file check, since they essentially do the same check.
| command([ | ||
| () => { | ||
| cp(join(sourcePath, "src/**/*.xml"), outDir); | ||
| // Re-target join(widgetRoot,...) after PR #182. |
Collaborator
There was a problem hiding this comment.
Should we retarget the full path after #182? The widgetRoot path in that branch probably also uses full paths with drive letters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
This PR contains
What is the purpose of this PR?
Fix Windows builds producing an .mpk missing the widget's .xml files and icon/tile PNGs.
...
Relevant changes
The copy step used absolute drive-letter globs that fast-glob returns empty for on Windows, so the widget files were silently skipped; switched both rollup configs to relative globs and added an assertion in command-tests so an incomplete .mpk
What should be covered while testing?
Build on Windows and Linux; confirm the .mpk contains package.xml and .xml (and PNGs when present in src).
...