Skip to content

FIX: improve reset warning spacing and show actual expiry countdown - #49

Merged
merefield merged 2 commits into
mainfrom
fix/reset-warning-countdown
Sep 11, 2026
Merged

FIX: improve reset warning spacing and show actual expiry countdown#49
merefield merged 2 commits into
mainfrom
fix/reset-warning-countdown

Conversation

@merefield

@merefield merefield commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Why

Give the expiry hazard symbol more breathing room and make the Resets-page warning distinguish actual time remaining from the configured warning lead time.

Changes

  • Add a second space after the hazard symbol in full and compact warnings across all 17 locales.
  • Replace EXPIRING SOON // within 72 hours with a live countdown such as FIRST EXPIRATION IN 2D 4H // within 72 hours on the Resets page.
  • Reuse the same countdown formatter for the top warning and the inventory notice; retain the configured lead time after //.
  • Update translations and README guidance without changing redemption or confirmation behaviour.

Verification

  • Full Go test suite and go vet ./....
  • Targeted reset race tests.
  • New countdown and spacing regressions, also run in all 17 locale subprocesses.
  • Existing responsive warning/button hit-surface tests cover the wider labels.
  • Local binary rebuilt for review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Improves reset expiry warnings with live countdowns, better spacing, localized updates, and regression coverage.

Changes:

  • Adds shared countdown formatting for reset warnings.
  • Updates spacing and translations across supported locales.
  • Updates documentation and localization tests.
File summaries
File Summary
README.md Documents updated warning behavior.
internal/ui/reset_warning_test.go Tests countdown and spacing behavior.
internal/ui/quota_reset.go Implements countdown rendering.
internal/ui/localisation_test.go Tests behavior across locales.
internal/i18n/locales/zh-Hans.json Updates localized warning text.
internal/i18n/locales/tr.json Updates localized warning text.
internal/i18n/locales/sv.json Updates localized warning text.
internal/i18n/locales/ru.json Updates localized warning text.
internal/i18n/locales/pt-PT.json Updates localized warning text.
internal/i18n/locales/pt-BR.json Updates localized warning text.
internal/i18n/locales/nl.json Updates localized warning text.
internal/i18n/locales/nb.json Updates localized warning text.
internal/i18n/locales/ja.json Updates localized warning text.
internal/i18n/locales/it.json Updates localized warning text.
internal/i18n/locales/fr.json Updates localized warning text.
internal/i18n/locales/fi.json Updates localized warning text.
internal/i18n/locales/et.json Updates localized warning text.
internal/i18n/locales/es.json Updates localized warning text.
internal/i18n/locales/en-GB.json Updates localized warning text.
internal/i18n/locales/de.json Updates localized warning text.
internal/i18n/locales/da.json Updates localized warning text.
Review details
  • Files reviewed: 21/21 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@merefield
merefield merged commit 8f28325 into main Sep 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants