FIX: improve reset warning spacing and show actual expiry countdown - #49
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Improves reset expiry warnings with live countdowns, better spacing, localized updates, and regression coverage.
Changes:
- Adds shared countdown formatting for reset warnings.
- Updates spacing and translations across supported locales.
- Updates documentation and localization tests.
File summaries
| File | Summary |
|---|---|
README.md |
Documents updated warning behavior. |
internal/ui/reset_warning_test.go |
Tests countdown and spacing behavior. |
internal/ui/quota_reset.go |
Implements countdown rendering. |
internal/ui/localisation_test.go |
Tests behavior across locales. |
internal/i18n/locales/zh-Hans.json |
Updates localized warning text. |
internal/i18n/locales/tr.json |
Updates localized warning text. |
internal/i18n/locales/sv.json |
Updates localized warning text. |
internal/i18n/locales/ru.json |
Updates localized warning text. |
internal/i18n/locales/pt-PT.json |
Updates localized warning text. |
internal/i18n/locales/pt-BR.json |
Updates localized warning text. |
internal/i18n/locales/nl.json |
Updates localized warning text. |
internal/i18n/locales/nb.json |
Updates localized warning text. |
internal/i18n/locales/ja.json |
Updates localized warning text. |
internal/i18n/locales/it.json |
Updates localized warning text. |
internal/i18n/locales/fr.json |
Updates localized warning text. |
internal/i18n/locales/fi.json |
Updates localized warning text. |
internal/i18n/locales/et.json |
Updates localized warning text. |
internal/i18n/locales/es.json |
Updates localized warning text. |
internal/i18n/locales/en-GB.json |
Updates localized warning text. |
internal/i18n/locales/de.json |
Updates localized warning text. |
internal/i18n/locales/da.json |
Updates localized warning text. |
Review details
- Files reviewed: 21/21 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Give the expiry hazard symbol more breathing room and make the Resets-page warning distinguish actual time remaining from the configured warning lead time.
Changes
EXPIRING SOON // within 72 hourswith a live countdown such asFIRST EXPIRATION IN 2D 4H // within 72 hourson the Resets page.//.Verification
go vet ./....