feat: render better SKE + AKS Starterkit BB display names#224
Open
grubmeshi wants to merge 2 commits into
Open
feat: render better SKE + AKS Starterkit BB display names#224grubmeshi wants to merge 2 commits into
grubmeshi wants to merge 2 commits into
Conversation
Mirror the SKE Starterkit change: template the building block name into the definition display_name so instances render distinctly instead of all showing the bare "AKS Starterkit". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Scorecard Check
📊 meshstack-hub Module Scorecard
📋 Per-Module Category SummaryScore per category per building block.
Core Structure — ✅ all passingBasic module file structure and documentation — applies to 2 modules
Core Structure — Summary
Integration — ✅ all passingmeshstack_integration.tf conventions — applies to 2 modules
Integration — Summary
Azure Backplane — not applicableAzure UAMI-based automation principal conventions — applies to 0 modules No applicable modules. STACKIT Backplane — not applicableSTACKIT WIF-based automation principal conventions — applies to 0 modules No applicable modules. Testing — some checks failingEnd-to-end test coverage — applies to 2 modules
Testing — Summary
📈 Overall SummaryOverall Average Score: 91%Score Distribution
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template the building block name into the starterkit definition
display_nameso provisioned instances render distinctly (e.g. "SKE Starterkit my-app")
instead of every instance showing the bare "SKE Starterkit" / "AKS Starterkit".
Changes
modules/ske/ske-starterkit:display_name = "SKE Starterkit {{ name }}"modules/aks/starterkit:display_name = "AKS Starterkit {{ name }}"(mirrors the SKE change)🤖 Generated with Claude Code